Repository navigation
chore(ci): remove non-blocking CUA mid-stream gate from publish workflow - #246
Conversation
|
Claim — Ember (reviewer + merger lead). Task: review + merge PR #246, branch Scope: Stage 4 review of the workflow diff (publish job byte-identical, cua-mid-stream job + dead cua_force_fail input removed, script kept for local runs), then Stage 5 merge on a PASS verdict with checks green on the exact head, verified by SHA readback, then Stage 5.5 design/PRD sync. No release tag, no Play rollout change, nothing published. Checked before claiming: PR is open, mergeable, head 8fadc3e; no prior claim comments or reviews on this PR. |
|
Stage 4 review verdict: PASS — head 8fadc3e. Method: claude-code-review (parallel compliance + bug passes, independent validation per finding), verified from the actual diff in a real checkout plus lead readback of the workflow files via the GitHub API. Acceptance criteria, one line each:
Filed note (validated, NOT a fail): scripts/android-cua-smoke.py:1877–1880 still says the per-cycle filename matches the upload step's logcat-cycle-*.txt glob in publish-play-store.yml — that glob lived in the removed job and no longer exists. Comment-only staleness; file-naming behavior unchanged, nothing consumes the glob now. Optional follow-up: reword to note the naming is kept for local-run consistency. Not a merge blocker. Checks on this head: test, Typecheck and unit tests, build, Unsigned iOS Simulator build, Secret scan all SUCCESS; release + build-fdroid skipped (correct for a CI-only change). Ready for Stage 5 merge on this head. |
|
Merged. Merge commit 01a7b6b (main head, read back via API), merged 2026-11-14T16:42:56Z. Stage 4 verdict PASS comment 6880871622 on head 8fadc3e; checks green on that exact head at merge time. The cua-mid-stream gate job and the dead cua_force_fail input are gone from publish-play-store.yml; scripts/android-cua-smoke.py is kept for local runs. No release tag created, no Play rollout change, nothing published. Stage 5.5 (design/PRD sync) follows. |
|
Stage 5.5 — Design/PRD sync: DONE.
Task complete: Stage 4 PASS (comment 6880871622, head 8fadc3e), merged 01a7b6b, Stage 5.5 recorded here. |
Verdict: STALE gate, not an app regression
Publish run 43572233118 (head e7385a3, tag v0.4.18) failed only on job
cua-mid-stream("streaming NOT proven, cycle 1/5") while thepublishjob succeeded.text_length0 with session statusbusy— the server produced zero text tokens in ~60s while still working.MODEL_CAPABLEprobe (short prompt) passed minutes earlier on the same server/model (gpt-5.4).CUA_FORCE_FAILproof, and its cycles were empty.Why removal, not adjustment
cua-smoke.ymlon 2026-11-13 (commit e844493, "no credits to run it"); this job still spends gpt-5.4 credits on every manual dispatch.publishnever had aneeds:on it).What this PR does
cua-mid-streamjob from.github/workflows/publish-play-store.yml(~240 lines), plus the now-deadcua_force_faildispatch input.publish) with a short removal note dated 2026-11-14.scripts/android-cua-smoke.pyis KEPT for local runs (--mid-stream-exitstill works); one stale comment in it (referencing the removedcua_force_failinput) is corrected to the env-var form.publishjob is unchanged apart from its leading comment: same steps, noneeds:added or removed. YAML validated withyaml.safe_load; the workflow now has a single job,publish.Revival recipe (if this coverage is wanted back)
type == "text"parts, so a model that streams reasoning first looks like zero output.busy).DO NOT MERGE
Awaiting dispatcher/owner review. This PR only removes CI; it does not touch the Play rollout and publishes nothing.