Skip to content

feat(chat): preserve long prompts and add optional message timestamps - #234

Open
meramsey wants to merge 3 commits into
dzianisv:mainfrom
meramsey:feat/long-prompts-message-timestamps
Open

meramsey wants to merge 3 commits into
dzianisv:mainfrom
meramsey:feat/long-prompts-message-timestamps

Conversation

@meramsey

@meramsey meramsey commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the app-side 10,000-character composer limit so long prompts are preserved and the server decides whether a prompt is acceptable.
  • Add an opt-in Message timestamps setting (off by default) and display each message's local date/time using the selected app locale.
  • Preserve settings migrations by defaulting the new preference off for existing installs.

Validation

  • npm test (385 passing)
  • npm run typecheck
  • npm run check:versions
  • git diff --check

This is intentionally limited to prompt length and per-message timestamps; it does not change Android package identity or add a separate build variant.

@dzianisv

Copy link
Copy Markdown
Owner

Claim — triage lead (Ember, OpenCode Mobile Work Log row "Triage external PRs #215 and #234"): reviewing this PR against current main (bd840a7) for a merge / needs-rebase / close verdict. Verdict to follow on this thread.

@dzianisv

Copy link
Copy Markdown
Owner

Triage verdict: needs-rebase — left open for the author

Reviewed against current main bd840a72 (2026-11-13). Not mergeable as-is; do not merge.

Evidence

  • Head a462d176, base 4a23a056 vs main bd840a72 — mergeable: false, conflicts with current main (app/session/[id].tsx changed heavily since Nov 8 by PRs fix(android): keep chat composer above the keyboard (#194, #156) #236, fix(chat): auto-scroll transcript to newest message (#155) #238, feat(chat): read-only subagent sessions surface (#187) #241).
  • CI was green on the old head (test, build, typecheck, iOS simulator build all success) but must re-run after a rebase.
  • Content check: no applicationId change, no dependency upgrades. The long-prompt fix is not duplicated on main — maxLength={10000} is still present at app/session/[id].tsx:944 — and the timestamps feature is not on main either (src/lib/message-timestamp.ts does not exist there). The work is still wanted.
  • One flag: the .github/workflows/build.yml hunk adds SENTRY_DISABLE_AUTO_UPLOAD on PR runs. That touches a CI workflow — please keep it as a separate commit with its own justification, or drop it and let maintainers decide.

What the author needs to do

  1. git fetch upstream && git rebase upstream/main (resolve conflicts, notably in app/session/[id].tsx and src/stores/settings.ts) and force-push.
  2. CI must go green on the rebased head.
  3. Re-verify npm test + npm run typecheck after the rebase; confirm the settings migration still defaults timestamps off.

Triage claim: comment 6866450135. This triage row is now recorded as done for #234; the follow-up above belongs to the author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants