feat(gitignore): do not ignore check outputs the upstream reads from the committed repo - #2553
Merged
dyoshikawa merged 4 commits intoAug 1, 2026
Merged
Conversation
…the committed repo Decides #2487 (option 1): Cursor Bugbot and Rovo Dev's code reviewer only see .cursor/BUGBOT.md and .rovodev/.review-agent.md when they are checked into the repository, so gitignoring them disabled the very feature the checks adapters generate. - New committedOutput meta flag on the checks factory (documented for future adapters like Goose .agents/checks/), consulted by gitignore-derive: flagged outputs are skipped from derivation. - Derived .gitignore regenerated: the **/.cursor/BUGBOT.md and **/.rovodev/.review-agent.md entries are gone. - Docs: the Cursor checks note states the commit-to-activate behavior for both tools. Closes #2487 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rive paths Review follow-ups on PR #2553: deriveFileEntries gets the same committedOutput guard as deriveDirEntries (symmetry, in case checks ever moves derivation shape), and gitignore-entries.test.ts pins that neither committed check output is ever derived and that the flag stays meaningful (at least one checks factory sets it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decides #2487, taking its option 1: Cursor Bugbot and Rovo Dev's code reviewer read
.cursor/BUGBOT.md/.rovodev/.review-agent.mdfrom the committed repository — gitignoring them (the blanket generated-outputs rule) disabled the very feature the checks adapters generate. Consistent with the call PR #2545 made for the repo-committed.rovodev/config.yml/mcp.json.committedOutput?: booleanmeta flag on the checks factory (set forcursorandrovodev; documented so future committed-tree checks adapters — e.g. Goose.agents/checks/from Follow up Goose upstream updates: goose review checks surface, retired .gooseignore, custom agents (.agents/agents/*.md) #2404 — inherit the mechanism), consulted bygitignore-derive.ts..gitignoreregenerated: both entries are gone.Testing
pnpm cicheckgreen (incl.check:gitignoredrift on the regenerated file; all gitignore-derive tests pass).Closes #2487
🤖 Generated with Claude Code