feat: Silverstripe 6 compatibility (4.0)#21
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates this module’s Composer dependency constraints to allow installation on both Silverstripe 5 and Silverstripe 6 projects, aligning with the SS6 upgrade effort while keeping SS5 compatibility.
Changes:
- Widened
dnadesign/silverstripe-elementalandsilverstripe/frameworkrequirements to support^5 || ^6. - Widened dev requirement
silverstripe/recipe-testingto support^3 || ^4. - Updated Composer branch alias from
3.x-devto4.x-dev.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsirish
force-pushed
the
feature/ss6-compat
branch
from
6523e35 to
4524144
Compare
jsirish
changed the title
BREAKING CHANGE: Drop Silverstripe 5 support, require SS6 only. Changes: - composer.json: framework ^6, elemental ^6, vendor-plugin ^3 - require-dev: recipe-testing ^4 - branch-alias: 4.x-dev - phpunit.xml.dist: update to PHPUnit 11 format (source/include) - _config.php: remove deprecated define() constants - README: update requirements to SS6 - CI: add SS6 test matrix
jsirish
force-pushed
the
feature/ss6-compat
branch
from
4524144 to
f4655b4
Compare
| "extra": { | ||
| "branch-alias": { | ||
| "dev-master": "3.x-dev" | ||
| "dev-master": "4.x-dev" |
Member
Author
There was a problem hiding this comment.
The default branch is master — confirmed via gh api repos/dynamic/silverstripe-elemental-embedded-code --jq .default_branch. The dev-master alias is correct for this repository.
Comment on lines
28
to
32
| "require": { | ||
| "dnadesign/silverstripe-elemental": "^5", | ||
| "silverstripe/framework": "^5" | ||
| "dnadesign/silverstripe-elemental": "^6", | ||
| "silverstripe/framework": "^6", | ||
| "silverstripe/vendor-plugin": "^3" | ||
| }, |
Comment on lines
+15
to
17
| * silverstripe/recipe-cms: ^6 | ||
| * dnadesign/silverstripe-elemental: ^6 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE: Drop Silverstripe 5 support. This is a new major version (4.0) requiring Silverstripe 6 only.
Changes
framework ^6,elemental ^6,vendor-plugin ^3recipe-testing ^44.x-devsource/includereplaces deprecatedfilter/whitelist)define()constantsVersion History