This repository was archived by the owner on Oct 6, 2022. It is now read-only.
Open
Conversation
Author
|
@BrendanChou Are you interested in these changes or cleanup of your dependency management in general? I'd suggest you adopt something like poetry for dependency management and locking. I'd be willing to make the migration if it's of interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this fix because I have the latest setuptools, which broke everything. You really don't have your dependencies under control (I don't blame you, packaging in Python is a mess).
The install_requires in
setup.pyshould list the minimal packages needed to run it. So not setuptools, and not tox, and not pytest. These all belong in arequirements-dev.txtor similar.You should consider using a better method of specifying dependencies and generating package locks.
pipenv is good at thispoetry is better,but also does a lot of other things you might not need.