Make dev-ollama model list declarative with configMapGenerator#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/models/models.txtreliably.ConfigMapYAML with a declarative generator so adding/removing models updates rendered manifests automatically.Description
overlays/dev-ollama/models.txtcontaining one model per line with#comments supported.ollama-modelsConfigMap inoverlays/dev-ollamawith aconfigMapGeneratorinoverlays/dev-ollama/kustomization.yamlusingfiles: - models.txt=models.txtso the generated key is exactlymodels.txt.generatorOptions.disableNameSuffixHash: trueto keep the generated ConfigMap namedollama-modelsfor mount compatibility.overlays/dev-ollama/ollama-models-configmap.yamlresource reference.Testing
kustomizeand ran/tmp/kustomize-bin/kustomize build overlays/dev-ollamaand grepped forname: ollama-models, which succeeded.overlays/dev-ollama/models.txtchanges the rendered output by comparing SHA256 checksums before/after, which returned a changed result.models.txtkey and that the existing pull job still mounts theollama-modelsConfigMap at/models/models.txt(render validation succeeded).Codex Task