Add el-geometry - #289
Merged
Merged
Conversation
Contributor
Author
|
While this module works with the concept of Zephyr Cartesian coordinates introduced in dwavesystems/dwave-graphs#275, this module is independent of that PR. |
Contributor
Author
|
Note to reviewers: This is the first of a series. Subsequent clique-embedder PRs depend on this PR and can only follow once this merges. So would much appreciate a speedy review. |
boothby
approved these changes
Jul 30, 2026
Contributor
Author
|
Undid the creation of |
thisac
reviewed
Aug 17, 2026
SebastianGitt
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new package tree for clique embedder and adds the first module,
el_geometry.py, which implements the pure geometry of the L-shaped ("el") templates used to build clique embeddings on a defected Zephyr graph.Changes
minorminer/embedders/__init__.pyminorminer/embedders/clique/__init__.pyminorminer/embedders/clique/_zephyr/__init__.pyNew module
minorminer/embedders/clique/_zephyr/el_geometry.pycomputes ideal el-template geometry for Zephyr. All functions arek-agnostic (quotient) and depend only on the Zephyr grid sizemand the ideal topology, not on the tile sizetor on which nodes/edges a specific graph contains. Uses Zephyr Cartesian(x, y, k)coordinates followingdwave.graphs.ZephyrCartesianCoord.Matching tests:
tests/embedders/__init__.py,tests/embedders/clique/__init__.py,tests/embedders/clique/zephyr/__init__.py,tests/embedders/clique/zephyr/test_el_geometry.pyNote
This is the first piece of a larger Zephyr clique-embedder effort; it lands the geometry layer only, with no public API wired up yet.
AI use
Used AI to clean up my code and complete, edit documentation. Also used it to write the test suite. Checked and edited everything myself.