Repository navigation
Prepare 1.0.0 release: release workflow, action updates - #94
Merged
Merged
Conversation
- Add release workflow that checks the tag against the manifest version, runs the tests and attaches rohlikcz.zip to the published release - Bump actions/checkout to v7 and actions/setup-python to v7 - Give CI workflows read-only token permissions; allow manual hassfest runs - Add Dependabot config to keep GitHub Actions up to date - Bump version to 1.0.0 and drop beta notes from the README Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
Author
|
@claude please review this PR. Focus on correctness of the new release workflow (tag/version check, ZIP layout for HACS zip_release, upload step) and the action version bumps. |
|
Claude finished @dvejsada's task in 30s —— View job Review of PR #94: 1.0.0 release workflowThe release workflow looks correct overall. I found no blocking issues. The main thing to confirm before merging is the I read the diff and the repo files. I did not run the workflow, and I could not check the action versions against GitHub from this environment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yaml: runs when a release is published (or manually for an existing tag). It checks the tag against themanifest.jsonversion, runs the tests, buildsrohlikcz.zipwith the integration files at the archive root (whathacs.jsonzip_releaseexpects) and attaches it to the release.actions/checkoutto v7 andactions/setup-pythonto v7.1.0.0; drop beta-specific notes from the README and update manual install steps to userohlikcz.zip.Release steps after merge
Publish release
v1.0.0frommaster(not a pre-release). The workflow attaches the ZIP.🤖 Generated with Claude Code