Offload blocking YAML dump to executor in sensor.py#806
Draft
Moustachauve wants to merge 1 commit intodvd-dev:mainfrom
Draft
Offload blocking YAML dump to executor in sensor.py#806Moustachauve wants to merge 1 commit intodvd-dev:mainfrom
Moustachauve wants to merge 1 commit intodvd-dev:mainfrom
Conversation
The `_save_history` method in `HiloRewardSensor` was performing a synchronous `yaml.dump` on the main event loop, causing blocking. This change offloads the serialization to the default executor using `asyncio.get_running_loop().run_in_executor`, ensuring the main loop remains responsive. Fixes the TODO item at custom_components/hilo/sensor.py:781.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_save_historymethod inHiloRewardSensorwas performing a synchronousyaml.dumpon the main event loop, causing blocking. This change offloads the serialization to the default executor usingasyncio.get_running_loop().run_in_executor, ensuring the main loop remains responsive.Fixes the TODO item at custom_components/hilo/sensor.py:781.
Created from Moustachauve/WLED-Android#55 in Jules