feat & fix: better handling about the access rate#793
Open
zopanix wants to merge 4 commits intodvd-dev:mainfrom
Open
feat & fix: better handling about the access rate#793zopanix wants to merge 4 commits intodvd-dev:mainfrom
zopanix wants to merge 4 commits intodvd-dev:mainfrom
Conversation
Collaborator
|
Je t'oublies pas je veux juste m'assurer que d'autres trucs marchent avant d'ajouter des feat. |
Collaborator
|
Salut @zopanix j'ai commencé à regarder ça un peu et pour là j'ai pas d'objections. Je me suis permis de le retravailler un peu. J'aimerais que tu me mettes la fonction _handle_state_change async sinon on va avoir quelques soucis: Sinon merci d'utiliser du lazy formating sur le logging. C'est une meilleure pratique car le formatage se fait uniquement si la ligne de logging tourne, et non en tout temps. |
This new rate also includes the access rate which provides you with a more accurate total cost
Retiré un update de trop, lint check
Ajout d'un display precision dans le GUI, j'avais à peu près 17 décimales
Collaborator
|
@zopanix il va manquer quelques doc strings pour que les linters soient content aussi. Si tu as un moment pour faire les petits correctifs ça va me faire plaisir de merger ça pour la prochaine version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution contains two changes: