Repository navigation
bar lyrics: sweep the word highlight right to left for RTL text - #4272
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bar's lyric line (
MediaLyricLine.qml) always filled the highlighted text from the left edge. For RTL lyrics such as Arabic, the word-by-word sweep ran left to right, against the reading direction.The highlighted copy of the text now anchors to the right edge when
LyricsModel.isRtl()is true, so the fill grows from right to left. This is the same detection the dash lyrics view already uses. LTR lyrics are unchanged.The component is also used by
MediaActivityFace.qml, so that surface gets the same fix.Type of change
Screenshots / video
2026-11-14.19-38-43.mp4
Arabic track (Masr7ya, Marwan Pablo) in the bar's music widget with smooth lyrics on: the highlight now fills right to left. The English track at the end still fills left to right.
Tested on niri.
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings