Skip to content

bar lyrics: sweep the word highlight right to left for RTL text - #4272

Merged
purian23 merged 2 commits into
duxlabs-dev:masterfrom
UsiFX:fix-bar-lyrics-rtl
Nov 14, 2026
Merged

purian23 merged 2 commits into
duxlabs-dev:masterfrom
UsiFX:fix-bar-lyrics-rtl

Conversation

@UsiFX

@UsiFX UsiFX commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Description

The bar's lyric line (MediaLyricLine.qml) always filled the highlighted text from the left edge. For RTL lyrics such as Arabic, the word-by-word sweep ran left to right, against the reading direction.

The highlighted copy of the text now anchors to the right edge when LyricsModel.isRtl() is true, so the fill grows from right to left. This is the same detection the dash lyrics view already uses. LTR lyrics are unchanged.

The component is also used by MediaActivityFace.qml, so that surface gets the same fix.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Screenshots / video

2026-11-14.19-38-43.mp4

Arabic track (Masr7ya, Marwan Pablo) in the bar's music widget with smooth lyrics on: the highlight now fills right to left. The English track at the end still fills left to right.

Tested on niri.

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dux-docs to document any new behaviors: https://github.com/duxlabs-dev/dux-docs

@github-actions github-actions Bot added fix ui Quickshell UI under quickshell/ labels Nov 14, 2026
@purian23
purian23 merged commit 2cb0df6 into duxlabs-dev:master Nov 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix ui Quickshell UI under quickshell/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants