Skip to content

fix(DankKDEConnect): fix notifications overflow #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbedward merged 1 commit into from
Nov 9, 2026
Merged

fix(DankKDEConnect): fix notifications overflow #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions DankKDEConnect/DankKDEConnect.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,14 +1407,15 @@ PluginComponent {
id: mainDeviceContainerRow
width: parent.width
height: {
const contentHeight = mainInfoColumn.implicitHeight + Theme.spacingM * 2;
if (!root.showDevicePlaceholder) {
return mainInfoColumn.implicitHeight + Theme.spacingM * 2;
return contentHeight;
}
const type = root.activeDevice?.type;
if (type === "desktop" || type === "computer" || type === "laptop" || type === "tablet" || type === "tv") {
return Math.max(mainInfoColumn.implicitHeight + Theme.spacingM * 2, 160);
return Math.max(contentHeight, 160);
}
return 245;
return Math.max(contentHeight, 245);
}
spacing: Theme.spacingM
visible: root.hasDevice
Expand Down
8 changes: 7 additions & 1 deletion DankKDEConnect/components/InfoRow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RowLayout {
property color valueColor: Theme.surfaceText

spacing: Theme.spacingM
width: parent.width
Layout.fillWidth: true

DIcon {
name: root.icon
Expand All @@ -28,17 +28,23 @@ RowLayout {
Layout.alignment: Qt.AlignVCenter

StyledText {
width: parent.width
text: root.label
font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText
font.weight: Font.Medium
wrapMode: Text.NoWrap
elide: Text.ElideRight
}

StyledText {
width: parent.width
text: root.value
font.pixelSize: Theme.fontSizeMedium
color: root.valueColor
font.weight: Font.Medium
wrapMode: Text.NoWrap
elide: Text.ElideRight
}
}
}
7 changes: 4 additions & 3 deletions DankKDEConnect/components/KDEConnectDetailContent.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,14 +514,15 @@ Item {
id: detailDeviceContainerRow
width: parent.width
height: {
const contentHeight = detailInfoColumn.implicitHeight + Theme.spacingM * 2;
if (!root.showDevicePlaceholder) {
return detailInfoColumn.implicitHeight + Theme.spacingM * 2;
return contentHeight;
}
const type = root.activeDevice?.type;
if (type === "desktop" || type === "computer" || type === "laptop" || type === "tablet" || type === "tv") {
return Math.max(detailInfoColumn.implicitHeight + Theme.spacingM * 2, 160);
return Math.max(contentHeight, 160);
}
return 255;
return Math.max(contentHeight, 255);
}
spacing: Theme.spacingM
visible: root.hasDevice
Expand Down
Loading