Allow setting of favourite serp easter egg logo #7467
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
changed the title
mikescamell
force-pushed
the
feature/mike/allow-setting-of-favourite-serp-easter-egg-logo
branch
from
f2ffff9 to
19e36d2
Compare
This will act as a kill switch, we don't want people stuck with a favourite icon and no way to turn it off if we can help it!
We now include a title to tell the user they have discovered an easter egg logo and allow them to set the logo as their favourite via the newly added button on screen.
When an Easter Egg logo is displayed in the omnibar (from a special search like "f1"), it now plays a subtle wiggle animation once the image loads. The animation: - Only plays once per unique logo URL (prevents re-triggering on ViewState updates) - Skips animation for favourite logos (set by user preference) - Waits 1 second after image loads for crossfade to complete
When a SERP page loads with an Easter Egg logo, two events occur in non-deterministic order: onViewModeChanged and onExternalOmnibarStateChanged. If onViewModeChanged was called after the Easter Egg was already set, it would overwrite the leadingIconState with Dax because it always passed logoUrl = null. This fix preserves the existing Easter Egg URL in onViewModeChanged by extracting it from the current state before updating, following the same pattern already used in onExternalLoadingStateChanged.
When navigating between searches, onExternalOmnibarStateChanged may be called with serpLogo = null before the new logo extraction completes. Previously this would clear the existing Easter Egg logo, causing Dax to briefly flash or persist if timing was unfavorable. Now we distinguish between: - SerpLogo.Normal: Explicitly no Easter Egg, clear and show Dax - null: Unknown/pending state, preserve existing Easter Egg if present This prevents the logo from being lost during navigation between Easter Egg searches.
mikescamell
force-pushed
the
feature/mike/allow-setting-of-favourite-serp-easter-egg-logo
branch
from
19e36d2 to
3b8dd59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1212553599261552?focus=true
Description
This PR adds the ability for users to set a SERP Easter Egg logo as their favourite, which will then display on all DuckDuckGo search result pages.
Features implemented:
- Display a title telling the user they've discovered an Easter Egg logo
- Added a button to set/unset the logo as favourite
- Only plays once per unique logo URL
- Skips animation for favourite logos
- Waits for image crossfade to complete before animating
- Preserve existing Easter Egg when onViewModeChanged is called
- Distinguish between SerpLogo.Normal (explicitly no Easter Egg) and null (pending state)
- Reset to Dax logo when favourite preference changes
Steps to test this PR
Easter Egg Discovery
Setting a Favourite Logo
Resetting to Default
Flag off
UI changes