Repository navigation
fix: make fresh source rebuilds bounded and recoverable - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh source rebuilds could stall after short detached stages, lose source-frame correspondence during cleaning, fail on fresh object coordinates or empty GPU caches, and freeze browser playback when a PCM soundtrack was embedded in MOV. This change fixes those paths while retaining bounded provider permits, original media, failed attempts, and unchanged quality thresholds.
Validation: 1,317 Python tests passed locally, including 22 new visibility regressions; five production-CLI synthetic fixtures, Ruff, repository formatting, and independent diff review passed. Prior local checks passed 283 viewer unit tests, six admin tests, and the production viewer build. Actual in-app browser checks confirmed both fresh 120-frame avatars, three bottle throws, final-frame visibility, sound-enabled playback, pause/seek, and loop wrap through the normal scene endpoint. All four CI jobs passed on commit
6d12151.The fresh rebuild is not a full E2E quality pass. The original run reached 15/19 stages before the generated room and scale-fit checks failed. One explicitly approved image-conditioned replacement restored the open landing, using 1,580 World Labs credits, but source-matched beginning/middle/end views still show missing interior stairs and an invented raised wedge. The corrected scale check also remains failed; placement, anchors, and accepted final verification have not advanced. Original assets and failure evidence are preserved. Media, credentials, generated outputs, and local evidence are excluded from this PR.
Independent code reviews were completed. The Bugbot-specific review tool was unavailable; no Bugbot pass is claimed.