Repository navigation
fix: skip shot ranking during cut rejection checks - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--reject-cutstold the cache it was skipping shot ranking, but the actual cut-detector command omitted--no-score. A clip with cuts could therefore load ranking models even though the run would reject it. Use the sameno_scorecondition for the command and cache key; detection/rejection and ordinary shot ranking remain unchanged.Validation: regression fails before the fix and passes after it; all 1,040 Python tests, repository format check and Python lint pass. Independent review found no issues.
Also records the actual-agent retained bottle delivery check: one detached package stage (78.3 s), supervisor wakeup, one successful database attempt, and a viewer review question. All 240 animated frames and retained room/audio/object assets match the prior package; browser playback, final-frame visibility, looping and unrestricted movement passed. No provider commands or quality acceptance occurred. Evidence remains local under
.context/evidence/bottle-agent-delivery/.