Improve ChyoaParser: recursive tree walk with nested TOC EPUB output#2764
Open
ARYAN-9099 wants to merge 2 commits into
Open
Improve ChyoaParser: recursive tree walk with nested TOC EPUB output#2764ARYAN-9099 wants to merge 2 commits into
ARYAN-9099 wants to merge 2 commits into
Conversation
dteviot
requested changes
Jul 3, 2026
dteviot
left a comment
dteviot
left a comment
Owner
There was a problem hiding this comment.
This does not collect images.
Have a look at Parser.js, line 604 where fetchImagesUsedInDocument() is called.
| let clone = contentEl.cloneNode(true); | ||
|
|
||
| // Remove CHYOA clutter: ads, ratings, navigation links | ||
| for (let sel of [ |
Owner
There was a problem hiding this comment.
Duplicates logic of removeUnwantedElementsFromContentElement. Should update that function and call it here
| constructor() { | ||
| super(); | ||
| // visitedUrls maps normalized URL → epub-item index. | ||
| // Tracks what we've already scraped to handle circular links. |
Owner
There was a problem hiding this comment.
Don't use the "s" word. It can cause problems with extension approval.
Author
|
@dteviot hey ive made the requested changes. please go ahead and review them again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello i'm pretty new to contributing on Github. Please tell if there are any mistakes.
Improve ChyoaParser to support recursive branching stories on CHYOA.
The previous parser only read a flat story-map, producing a broken linear EPUB. This PR updates ChyoaParser to:
p.meta a