Prevent resuming a saved preset - #4228
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The focused preset tests, Ruff checks, and Pyright pass on the current head. The fork workflow is |
|
Thanks for enabling the fork workflow. The full |
Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
|
I've synced this with current The saved preset continues to own completion and its list row; the expanded preset tests cover that behavior on the updated branch. |
Closes #4204.
What changed
I stop
dstack preset resumeoncepreset.ymlhas been committed. The saved preset also owns its list row, and its creation session supplies progress details.PresetStore.save()atomically publishes the artifact before run cleanup. The resume check now follows that durable completion point.Verification
e54083b7: 353 passed, 2 skipped.