Skip to content

Update CHANGELOG.md - #2

Closed
dso-amd wants to merge 1 commit into
developfrom
dso-amd-patch-1
Closed

Update CHANGELOG.md#2
dso-amd wants to merge 1 commit into
developfrom
dso-amd-patch-1

Conversation

@dso-amd

@dso-amd dso-amd commented May 20, 2026

Copy link
Copy Markdown
Owner

Correct ROCm release number, plus a minor edit.

Correct ROCm release number, plus a minor edit.
@dso-amd dso-amd added the documentation Improvements or additions to documentation label May 20, 2026
@dso-amd

dso-amd commented May 20, 2026

Copy link
Copy Markdown
Owner Author

It shouldn't be merged into here. PR created for merging into ROCm/rocm-libraries.

@dso-amd dso-amd closed this May 20, 2026
dso-amd pushed a commit that referenced this pull request May 26, 2026
## Motivation

https://amd-hub.atlassian.net/browse/AIHPBLAS-1467

## Technical Details

Fixed multiple issues preventing TensileLight from correctly generating
and executing kernels when UseBeta=false (beta parameter not used in
GEMM operations). Enabled bounds checking validation to work correctly
with this configuration.

Files Modified
1. Tensile/KernelWriterAssembly.py
Issue: KeyError when accessing Beta SGPR register when UseBeta=false
Fix: Added conditional check before accessing Beta SGPR
if kernel["ProblemType"]["UseBeta"]:
moduleExternalArgs.addComment("Read Beta")

moduleExternalArgs.addModuleAsFlatItems(self.externalArgLoader.loadAllKernArg(
self.sgprs["Beta"], "KernArgAddress", self.states.numSgprBeta))
2. Tensile/SolutionStructs/Problem.py
Issue: UseBeta serialized as integer (0/1) instead of boolean in YAML,
causing C++ parser errors
Fix: Ensure UseBeta is always stored as boolean
self.state["UseBeta"] = bool(self.state["UseBeta"])
3. client/src/ReferenceValidator.cpp
Issue #1: Buffer allocation check didn't verify if buffer pointer was
valid
Fix: Check both size and pointer validity
// Only skip reallocation if size matches AND buffer is valid
if(m_cpuResultBufferSize == bytes && m_cpuResultBuffer.get() != nullptr)
return;
Issue #2: hipFree compiler warning about nodiscard attribute
Fix: Cast return value to void in lambda deleter
uint8_t* buffer;
HIP_CHECK_EXC(hipHostMalloc((void**)&buffer, bytes, 0));
m_cpuResultBuffer.reset(buffer, [](uint8_t* p) { (void)hipFree(p); });
Issue ROCm#3: Attempting to validate null/empty tensors
Fix: Skip validation for null pointers or zero-sized tensors
// Skip validation if pointers are null or maxElements is 0
if(resPtr == nullptr || refPtr == nullptr || result.maxElements[i] == 0)
{
if(Debug::Instance().printTensorInfo())
std::cout << "Skipping validation for tensor " << tensor.getName() <<
std::endl;
continue;
}
Issue ROCm#4: Trying to copy padding bytes from output tensors that don't
have padding
Fix: Only use maxElement for input tensors
// For output tensors, don't use maxElement with padding
if(boundsCheck == BoundsCheckMode::NaN && !tensor.isOutput())
elementsToCopy = maxElement;
Issue ROCm#5: Bounds checking validation on output tensors without padding
buffers
Fix: Skip bounds checking for output tensors
// Only check bounds for input tensors (output tensors don't have
padding buffers)
if(boundsCheck == BoundsCheckMode::NaN && !tensor.isOutput())
4. client/src/DataInitialization.cpp
Issue: hipMemcpy with null pointers causing runtime errors
Fix: Added null pointer check
void* copyInputBuffers(const TensorDescriptor& descriptor,
void* dst,
void* src,
size_t totalElements,
hipMemcpyKind kind)
{
// Skip copy if no elements to copy or if pointers are null
if(totalElements > 0 && dst != nullptr && src != nullptr)
{
HIP_CHECK_EXC(hipMemcpy(dst, src, descriptor.elementBytes() *
totalElements, kind));
}
return dst;
}


ROCm@0d6cd23
## Test Plan

NA

## Test Result

```
========================================================================================== 105 passed, 83 skipped, 1 warning in 1040.87s (0:17:20) ==========================================================================================
```

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com>
dso-amd pushed a commit that referenced this pull request Jun 26, 2026
## Motivation

The current top of tree ctests for sanity testing (test 1 & test 2) do
not run from external directories. This PR will allow these tests to run
from any directory

## Technical Details

Use ctests built-in `build-and-test` instead of building separately

## Test Plan

Run ctests

## Test Result
From a directory outside of actual build directory

```
lakshmi@kapu:~/work/rpp-test$ ctest -VV -I 1,2,1
UpdateCTestConfiguration  from :/home/lakshmi/work/rpp-test/DartConfiguration.tcl
Parse Config file:/home/lakshmi/work/rpp-test/DartConfiguration.tcl
UpdateCTestConfiguration  from :/home/lakshmi/work/rpp-test/DartConfiguration.tcl
Parse Config file:/home/lakshmi/work/rpp-test/DartConfiguration.tcl
Test project /home/lakshmi/work/rpp-test
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 1
    Start 1: rpp_sanity_test_brightness_host_f32

1: Test command: /usr/local/bin/ctest "--build-and-test" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/HOST" "/home/lakshmi/work/rpp-test/HOST" "--build-generator" "Unix Makefiles" "--test-command" "Tensor_image_host" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/work/rpp-test/HOST/output" "2" "0" "0" "0" "1" "0" "0" "1" "0" "0" "1" "0" "0" "0" "0" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test"
1: Working Directory: /home/lakshmi/work/rpp-test
1: Test timeout computed to be: 1500
1: Internal cmake changing into directory: /home/lakshmi/work/rpp-test/HOST
1: ======== CMake output     ======
1: HIP: Using hipcc from relative path: /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/bin/hipcc
1: -- test_suite/HOST: rpp found with find_package(rpp QUIET)
1: --   rpp_INCLUDE_DIR -- /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/include
1: --   rpp_LIBRARY -- /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librpp.so
1: --   rpp_BACKEND_TYPE -- HIP
1: --   rpp_AUDIO_AUGMENTATIONS_SUPPORT -- OFF
1: -- test_suite/HOST is supported to build and run with RPP HIP backend installation
1: -- Python3 found at /usr/bin/python3.11
1: -- test_suite/HOST All Tensor HOST tests set to build with OpenMP
1: -- test_suite/HOST Tensor-Image HOST tests set to build with OpenCV (decoder_type 1 and image dumps enabled)
1: -- Tensor_image_host -- Link Libraries: see target_link_libraries
1: -- test_suite/HOST Tensor-Voxel HOST tests set to build with libniftiio
1: -- test_suite/HOST Tensor-Voxel HOST tests set to build with OpenCV (slice JPG dumps enabled)
1: -- Warning: RPP_AUDIO_SUPPORT not found in RPP installation. It must be installed to build test_suite/HOST Tensor-Audio tests successfully!
1: Configuring done
1: Generating done
1: Build files have been written to: /home/lakshmi/work/rpp-test/HOST
1: ======== End CMake output ======
1: Change Dir: /home/lakshmi/work/rpp-test/HOST
1:
1: Run Clean Command:/usr/bin/gmake -f Makefile clean
1:
1: Run Build Command(s):/usr/bin/gmake -f Makefile && [ 16%] Building CXX object CMakeFiles/Tensor_image_host.dir/Tensor_image_host.cpp.o
1: [ 33%] Linking CXX executable Tensor_image_host
1: [ 33%] Built target Tensor_image_host
1: [ 50%] Building CXX object CMakeFiles/Tensor_voxel_host.dir/Tensor_voxel_host.cpp.o
1: [ 66%] Linking CXX executable Tensor_voxel_host
1: [ 66%] Built target Tensor_voxel_host
1: [ 83%] Building CXX object CMakeFiles/Tensor_misc_host.dir/Tensor_misc_host.cpp.o
1: [100%] Linking CXX executable Tensor_misc_host
1: [100%] Built target Tensor_misc_host
1:
1: Running test command: "/home/lakshmi/work/rpp-test/HOST/Tensor_image_host" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/work/rpp-test/HOST/output" "2" "0" "0" "0" "1" "0" "0" "1" "0" "0" "1" "0" "0" "0" "0" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test"
1:
1: Inputs for this test case are:
1: src1 = /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1
1: src2 = /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1
1: dst = /home/lakshmi/work/rpp-test/HOST/output
1: u8 / f16 / f32 / u8->f16 / u8->f32 / i8 / u8->i8 (0/1/2/3/4/5/6) = 2
1: outputFormatToggle (pkd->pkd = 0 / pkd->pln = 1) = 0
1: case number (0:101) = 0
1: number of times to run = 1
1: test type - (0 = unit tests / 1 = performance tests) = 0
1: layout type - (0 = PKD3 / 1 = PLN3 / 2 = PLN1) = 0
1: qa mode - 0/1 = 0
1: decoder type - (0 = packed .rgb / 1 = OpenCV) = 0
1: batch size = 1
1: Running brightness_f32_Tensor_HOST_PKD3_toPKD3 1 times (each time with a batch size of 1 images) and computing mean statistics...
1:
1: Execution Timings for Iteration 1:
1: CPU Backend Clock Time: 0.046 ms/batch
1: CPU Backend Wall Time: 0.0491142 ms/batch
1:
1: Execution Timings for Iteration 2:
1: CPU Backend Clock Time: 0.062 ms/batch
1: CPU Backend Wall Time: 0.0629425 ms/batch
1:
1: Execution Timings for Iteration 3:
1: CPU Backend Clock Time: 0.061 ms/batch
1: CPU Backend Wall Time: 0.0619888 ms/batch
1:
1/2 Test #1: rpp_sanity_test_brightness_host_f32 ...   Passed    6.16 sec
test 2
    Start 2: rpp_sanity_test_brightness_hip_f32

2: Test command: /usr/local/bin/ctest "--build-and-test" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/HIP" "/home/lakshmi/work/rpp-test/HIP" "--build-generator" "Unix Makefiles" "--test-command" "Tensor_image_hip" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/work/rpp-test/HIP/output" "2" "0" "0" "0" "1" "0" "0" "1" "0" "0" "1" "0" "0" "0" "0" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test"
2: Working Directory: /home/lakshmi/work/rpp-test
2: Test timeout computed to be: 1500
2: Internal cmake changing into directory: /home/lakshmi/work/rpp-test/HIP
2: ======== CMake output     ======
2: HIP: Using hipcc from relative path: /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/bin/hipcc
2: -- test_suite/HIP: rpp found with find_package(rpp QUIET)
2: --   rpp_INCLUDE_DIR -- /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/include
2: --   rpp_LIBRARY -- /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librpp.so
2: --   rpp_BACKEND_TYPE -- HIP
2: --   rpp_AUDIO_AUGMENTATIONS_SUPPORT -- OFF
2: -- test_suite/HIP is supported to build and run with RPP HIP backend installation
2: HIP: Using hipcc from relative path: /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/bin/hipcc
2: -- HIP found at HIP_INCLUDE_DIRS - /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/include and HIP_LIBRARIES - hip::host;hip::device
2: -- Python3 found at /usr/bin/python3.11
2: -- test_suite/HIP All Tensor HIP tests set to build with OpenMP
2: -- test_suite/HIP Tensor-Image HIP tests set to build with OpenCV (decoder_type 1 and image dumps enabled)
2: -- Tensor_image_hip -- Link Libraries: see target_link_libraries
2: -- test_suite/HIP Tensor-Voxel HIP tests set to build with libniftiio
2: -- test_suite/HIP Tensor-Voxel HIP tests set to build with OpenCV (slice JPG dumps enabled)
2: -- Tensor_voxel_hip -- Link Libraries: see target_link_libraries
2: -- Warning: RPP_AUDIO_SUPPORT not found in RPP installation. It must be installed to build test_suite/HIP Tensor-Audio tests successfully!
2: -- Tensor_misc_hip -- Link Libraries: rpp::rpp;hip::host;hip::device;stdc++fs;OpenMP::OpenMP_CXX
2: Configuring done
2: Generating done
2: Build files have been written to: /home/lakshmi/work/rpp-test/HIP
2: ======== End CMake output ======
2: Change Dir: /home/lakshmi/work/rpp-test/HIP
2:
2: Run Clean Command:/usr/bin/gmake -f Makefile clean
2:
2: Run Build Command(s):/usr/bin/gmake -f Makefile && [ 16%] Building CXX object CMakeFiles/Tensor_image_hip.dir/Tensor_image_hip.cpp.o
2: [ 33%] Linking CXX executable Tensor_image_hip
2: [ 33%] Built target Tensor_image_hip
2: [ 50%] Building CXX object CMakeFiles/Tensor_voxel_hip.dir/Tensor_voxel_hip.cpp.o
2: [ 66%] Linking CXX executable Tensor_voxel_hip
2: [ 66%] Built target Tensor_voxel_hip
2: [ 83%] Building CXX object CMakeFiles/Tensor_misc_hip.dir/Tensor_misc_hip.cpp.o
2: [100%] Linking CXX executable Tensor_misc_hip
2: [100%] Built target Tensor_misc_hip
2:
2: Running test command: "/home/lakshmi/work/rpp-test/HIP/Tensor_image_hip" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1" "/home/lakshmi/work/rpp-test/HIP/output" "2" "0" "0" "0" "1" "0" "0" "1" "0" "0" "1" "0" "0" "0" "0" "/home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test"
2:
2: Inputs for this test case are:
2: src1 = /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1
2: src2 = /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/share/rpp/test/TEST_IMAGES/three_images_mixed_src1
2: dst = /home/lakshmi/work/rpp-test/HIP/output
2: u8 / f16 / f32 / u8->f16 / u8->f32 / i8 / u8->i8 (0/1/2/3/4/5/6) = 2
2: outputFormatToggle (pkd->pkd = 0 / pkd->pln = 1) = 0
2: case number (0:101) = 0
2: number of times to run = 1
2: test type - (0 = unit tests / 1 = performance tests) = 0
2: layout type - (0 = PKD3/ 1 = PLN3/ 2 = PLN1) = 0
2: qa mode - 0/1 = 0
2: decoder type - (0 = packed .rgb / 1 = OpenCV) = 0
2: batch size = 1
2: Running brightness_f32_Tensor_HIP_PKD3_toPKD3 1 times (each time with a batch size of 1 images) and computing mean statistics...
2:
2: Execution Timings for Iteration 1:
2: GPU Backend Wall Time: 3.59392 ms/batch
2:
2: Execution Timings for Iteration 2:
2: GPU Backend Wall Time: 0.0441074 ms/batch
2:
2: Execution Timings for Iteration 3:
2: GPU Backend Wall Time: 0.0441074 ms/batch
2/2 Test #2: rpp_sanity_test_brightness_hip_f32 ....   Passed   13.04 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =  19.20 sec
```

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
dso-amd pushed a commit that referenced this pull request Jul 13, 2026
## Motivation

The `bsrsv`, `csrsv`, and `csrsm` kernels are using the restrict keyword
incorrectly.

### Incorrect `__restrict__`

`__restrict__` is a promise that the pointer is not accessed through any
other path, which
the optimizer is entitled to extend to "not modified by concurrent
threads."

## Technical Details

- Removed `__restrict__` from the read/write value pointers in
both the device function and the kernel wrapper of every affected
kernel.
- Also removed `__restrict__` from the `zero_pivot` / `singular_pivot`
pointers. These
are likewise modified by multiple work-groups, so the `noalias` contract
is incorrect.

JIRA ID : ROCM-27438
dso-amd pushed a commit that referenced this pull request Jul 13, 2026
## What

Make origami's installed `CTestTestfile.cmake` use paths relative to the
test
directory instead of `${CMAKE_CURRENT_LIST_DIR}`.

## Why

`${CMAKE_CURRENT_LIST_DIR}` is **empty** when `ctest` parses an
*installed*
`CTestTestfile.cmake` — its restricted parser does not populate that
variable
(unlike a normal configure or `cmake -P` run). The relocatable file
emitted by
ROCm#9047 used it for the test command, `WORKING_DIRECTORY`, and the
`LD_LIBRARY_PATH`/`PYTHONPATH` environment, so `WORKING_DIRECTORY`
expanded to
`""` and every test failed to launch:

```
Failed to change working directory to  : No such file or directory
1/2 Test #1: origami-tests ....................***Not Run
2/2 Test #2: origami_python_tests .............***Not Run
```

ctest already runs each test with its working directory defaulting to
the
directory containing the `CTestTestfile.cmake`, including under
`ctest --test-dir <dir>` invoked from an unrelated cwd. So relative
paths
resolve correctly and relocatably without the (empty) variable. This
also aligns
origami with the sibling hipBLASLt installed test file, which uses the
same
relative-path convention ("Tests are defined with relative paths to work
in the
installed location").

## Change

`shared/origami/tests/CMakeLists.txt` — in the installed
`_ctest_content`:
- `"${CMAKE_CURRENT_LIST_DIR}/../origami-tests"` → `"../origami-tests"`
- pytest target `"${CMAKE_CURRENT_LIST_DIR}/tests"` → `"tests"`
- dropped `WORKING_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}"` (default is
already the file's dir)
- env paths `${CMAKE_CURRENT_LIST_DIR}/../../lib[...]` →
`../../lib[...]`

## Verification

Reproduced and validated in
`ghcr.io/rocm/therock_build_manylinux_x86_64`
(ctest 3.27.9, python 3.12) against a real origami build. Both installed
`CTestTestfile.cmake` variants were generated by actual `cmake`
CONFIGURE from
the committed source and run via `ctest --test-dir` from an unrelated
cwd:

| | C++ `origami-tests` | `origami_python_tests` |
|---|---|---|
| Before (`${CMAKE_CURRENT_LIST_DIR}`) | Not Run | Not Run |
| After (relative) | Passed | Runs |

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
dso-amd pushed a commit that referenced this pull request Jul 13, 2026
## Summary

Raise the rocSPARSE `standard` CTest category timeout from 1800 s (30
min) to 3600 s (1 h) in `test_categories.yaml`.

ISSUE ID: ROCm#9251 (ROCm#9251)

## Why

`rocsparse-test_standard_suite` uses the `standard` category timeout as
its per-invocation CTest `TIMEOUT` property, which overrides TheRock's
`--timeout 7200`:

```
2: Test timeout computed to be: 1800
1/1 Test #2: rocsparse-test_standard_suite ....***Timeout 1800.30 sec
```

With GTest sharding each shard still gets the full 1800 s but runs ~1/3
of the ~18k cases in ~28-31 min, so the heaviest shard tips over the
30-min limit. Example (TheRock#6448, gfx950 shard 2/3): ~75% of cases
done (13,486 / 17,938) in 29 m 50 s before it was killed. Raising to
3600 s gives ~2x headroom over the observed shard runtime while staying
within the rocsparse CI job `timeout_minutes`. For comparison, rocBLAS
uses `standard: 7200` (2 h) across 6 shards.

## Bump PRs that observed this timeout (`Timeout 1800.30 sec`)

| Bump PR | rocsparse job |
|---|---|
| ROCm/TheRock#6448 | Test rocsparse (shard 2/3) — gfx950-dcgpu |
| ROCm/TheRock#6435 | Test rocsparse (shard 2/3) — gfx950-dcgpu |
| ROCm/TheRock#6417 | Test rocsparse (shard 1/1) — gfx950-dcgpu |
| ROCm/TheRock#6374 | Test rocsparse (shard 1/1) — gfx950-dcgpu |
| ROCm/TheRock#6356 | Test rocsparse (shard 1/1) — gfx950-dcgpu and
gfx94X-dcgpu |
| ROCm/TheRock#6327 | Test rocsparse (shard 1/1) — gfx950-dcgpu |
| ROCm/TheRock#6321 | Test rocsparse (shard 1/1) — gfx950-dcgpu |

Almost all instances are on the datacenter GPUs (gfx950/gfx94X). The
`1/1` entries are unsharded runs; the `2/3` entries show even the
current 3-way split still tips over.

## Alternative considered

Increasing the rocsparse shard count in TheRock
(`fetch_test_configurations.py`, currently 3 → e.g. 6) would cut each
shard to ~1/6 (~15 min), comfortably under the existing 30-min cap
without changing rocm-libraries. The two approaches are independent;
this PR takes the rocm-libraries-only timeout route.

## Test plan

- Config-only change to `test_categories.yaml`; no source code changed
(no new unit test required per repo policy).
- The `standard` suite's effective CTest timeout becomes 3600 s, so
shards running ~30 min no longer hit `***Timeout`.

Made with [Cursor](https://cursor.com)
dso-amd pushed a commit that referenced this pull request Jul 13, 2026
… uchar type (ROCm#9237)

## Motivation
This PR addresses compile warnings with Ofast flag. Instead changed to
use -fast-math


## Technical Details
Modified compile flags to use standard O3
Removed the use of uchar data-type from RPP test-suite which is only
defined in OpenCV

## Test Plan

CTests should pass

## Test Result

      Start  1: rpp_sanity_test_brightness_host_f32
1/10 Test #1: rpp_sanity_test_brightness_host_f32 ......... Passed 3.64
sec
      Start  2: rpp_sanity_test_brightness_hip_f32
2/10 Test #2: rpp_sanity_test_brightness_hip_f32 .......... Passed 7.75
sec
      Start  3: rpp_qa_tests_tensor_image_host_all
3/10 Test ROCm#3: rpp_qa_tests_tensor_image_host_all .......... Passed 42.43
sec
      Start  4: rpp_qa_tests_tensor_voxel_host_all
4/10 Test ROCm#4: rpp_qa_tests_tensor_voxel_host_all .......... Passed 2.26
sec
      Start  5: rpp_qa_tests_tensor_misc_host_all
5/10 Test ROCm#5: rpp_qa_tests_tensor_misc_host_all ........... Passed 7.74
sec
      Start  6: rpp_qa_tests_tensor_misc_host_test_type_1
6/10 Test ROCm#6: rpp_qa_tests_tensor_misc_host_test_type_1 ... Passed
402.60 sec
      Start  7: rpp_qa_tests_tensor_image_hip_all
7/10 Test ROCm#7: rpp_qa_tests_tensor_image_hip_all ........... Passed 84.44
sec
      Start  8: rpp_qa_tests_tensor_voxel_hip_all
8/10 Test ROCm#8: rpp_qa_tests_tensor_voxel_hip_all ........... Passed 4.62
sec
      Start  9: rpp_qa_tests_tensor_misc_hip_all
9/10 Test ROCm#9: rpp_qa_tests_tensor_misc_hip_all ............ Passed 16.50
sec
      Start 10: rpp_qa_tests_tensor_misc_hip_test_type_1
10/10 Test ROCm#10: rpp_qa_tests_tensor_misc_hip_test_type_1 .... Passed
348.19 sec

100% tests passed, 0 tests failed out of 10

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs-only documentation Improvements or additions to documentation project: hipsparselt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant