fix(visualization): address workspace review feedback - #37
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Reviewer's GuideCentralizes abort handling for workspace fixture data sources via a shared abortAware helper (with focused tests) and removes a redundant aria-label from the research context selector for better a11y. Sequence diagram for centralized abortAware loader behaviorsequenceDiagram
participant Caller
participant abortAware
participant Resolver
Caller->>abortAware: abortAware(resolver)
abortAware-->>Caller: WorkspaceLoader
Caller->>abortAware: WorkspaceLoader(signal)
alt [signal.aborted]
abortAware-->>Caller: Promise.reject(AbortError)
else [not aborted]
abortAware->>Resolver: resolver(signal)
Resolver-->>abortAware: Promise<T>
abortAware-->>Caller: Promise<T>
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Applies Sourcery review feedback from the Phase 6.9 workspace PR:
aria-labelon the context<select>(the<label htmlFor>association already provides the accessible name, avoiding double announcements).abortAwarehelper inlib/workspace/dataSources.ts(used by both interval and whole-dataset loaders viaresolveFixture), removing the duplicated local wrapper.abortAwaretests (run resolver when not aborted; reject withAbortErrorwithout running the resolver when already aborted).Validation: lint, typecheck, 725 vitest + 1606 pytest, turbo build,
git diff --checkall green.Summary by Sourcery
Unify abort-aware handling for workspace fixture data sources and tighten workspace UI accessibility.
Enhancements:
Tests: