Skip to content

perf: upgrade to jsonc-parser 0.31 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 1 commit into from
Mar 20, 2026
Merged

perf: upgrade to jsonc-parser 0.31 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rs_lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition = "2024"
crate-type = ["cdylib"]

[dependencies]
jsonc-parser = { version = "0.29.0", features = ["cst", "serde", "preserve_order", "error_unicode_width"] }
jsonc-parser = { version = "0.31.0", features = ["cst", "serde", "serde_json", "preserve_order", "error_unicode_width"] }
wasm-bindgen = "=0.2.106"
js-sys = "0.3"
serde = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion rs_lib/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ pub fn parse_to_value(

// Use the more efficient parse_to_serde_value API from jsonc_parser
// This skips building the full CST and directly produces a serde_json::Value
let serde_value = jsonc_parser::parse_to_serde_value(text, &parse_options)
let serde_value: Option<serde_json::Value> = jsonc_parser::parse_to_serde_value(text, &parse_options)
.map_err(|e| throw_error(&format!("Parse error: {}", e)))?;

// Convert serde_json::Value to JsValue using serde-wasm-bindgen with custom serializer
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[toolchain]
channel = "1.92.0"
channel = "1.94.0"
components = ["clippy", "rustfmt"]