Repository navigation
fix(imessage): the unknown-inbound ingester must not swallow GROUP messages - #252
Merged
Merged
Conversation
…ssages — parity with the WhatsApp guard Found by the introspection loop on its first successful audit in ~4 weeks (it wrote the fix + regression test before its run died on a network error, leaving them uncommitted). `maybeIngestUnknownInbound` was called without the `!isGroup` guard the WhatsApp bridge already has at its call site, so an appointment-shaped message in a GROUP could be claimed by the life-event/appointment ingester and the contact reply suppressed — a silent drop in a group thread. `isGroup` is already a parameter of the enclosing `handleInbound`; every sibling branch around it is `!isGroup`-gated. Verified: imessage-bridge 118/0 (incl. the new unknown-inbound-group-scope regression test), tsc clean.
Contributor
🔎 Codex cross-audit (agent:audit)Blocking: none. Findings: none. The PR’s runtime change correctly prevents Residual risk: the added test is source-grep coverage, not behavioral coverage, so it protects the current call-site shape but would not catch all future refactors. I did not run the Vitest suite in this read-only sandbox; |
Contributor
🔷 Gemini cross-audit (agent:audit-gemini)Audit Result: LGTM (No Blocking Issues)
|
Contributor
🛡️ Vuln scan — ❌ vulnerable dependency found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the introspection loop on its first successful audit in ~4 weeks — it wrote the fix and a regression test, then its run died on a network error (
ENOTFOUND), leaving the work uncommitted in the tree. I verified the claim independently before committing.The bug
maybeIngestUnknownInboundwas called inhandleInboundwithout the!isGroupguard that the WhatsApp bridge already has at its equivalent call site (services/whatsapp-bridge/src/session.ts:3423). An appointment-shaped message in a group could therefore be claimed by the life-event/appointment ingester, suppressing the contact reply — a silent drop in a group thread, which is exactly the class of failure the "never silent" rule exists to prevent.isGroupis already a parameter of the enclosinghandleInbound, and every sibling branch around it (lines 7317 / 7331 / 7353) is!isGroup-gated. This one was the outlier.Verification
unknown-inbound-group-scope.test.ts(new)