wiz_socket: fix rx ring buffer wrap#11
Open
chall37 wants to merge 1 commit into
Open
Conversation
In the wrap-around branch of getFromRealSocket() and loopback(), the second memcpy uses `&rxbuf` (the address of the rxbuf pointer) instead of `rxbuf` (the buffer it points to). `&rxbuf[idx]` is a pointer to byte idx of the buffer. `&rxbuf` is the address of the rxbuf member. This results in OOB writes and/or data corruption of the socket's own members. Reproducible with DHCP loopback across repeated AVR resets in a single simulavr session (~3-4 cycles should be enough to trip it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the wrap-around branch of getFromRealSocket() and loopback(), the second memcpy uses
&rxbuf(the address of the rxbuf pointer) instead ofrxbuf(the buffer it points to).&rxbuf[idx]is a pointer to byte idx of the buffer.&rxbufis the address of the rxbuf member. This results in OOB writes and/or data corruption of the socket's own members.Reproducible with DHCP loopback across repeated AVR resets in a single simulavr session (~3-4 cycles should be enough to trip it).