fix: block finalize while paused - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #36 by choosing the symmetric fix:
finalizeis now blocked while paused, alongsideassert_outcome,dispute, andresolve. Previously a pending assertion could finalize uncontested even if its entire challenge window overlapped a pause, during whichdisputewas blocked, so it had no real opportunity to be challenged.The alternative (extending the challenge window deadline by the pause duration) is the more precise fix but adds real state-tracking complexity. Deliberately deferred to a later version; noted in ARCHITECTURE.md so it isn't lost.
Updated:
set_paused/finalizedoc comments, ARCHITECTURE.md, CONTRACT.md, DEPLOYMENT.md, GLOSSARY.md, INTEGRATION.md, CHANGELOG.md. Renamed the two tests whose names or premise described the old behavior, and regenerated their snapshots.Test plan
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepass locally (67 tests)CONTRACT.mdupdated (interface behavior changed:finalizenow fails withPaused)scripts/testnet-smoke.shnot run; this only changes pause-interaction behavior, not the core assert/dispute/resolve flow it exercises