Skip to content

fix(web): translate Blend faucet toast messages - #436

Merged
collinsezedike merged 1 commit into
drydocs:mainfrom
Caneryy:feat/issue-426
Jul 30, 2026
Merged

fix(web): translate Blend faucet toast messages#436
collinsezedike merged 1 commit into
drydocs:mainfrom
Caneryy:feat/issue-426

Conversation

@Caneryy

@Caneryy Caneryy commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • useBlendFaucet.ts's toast strings for the faucet funding flow were hardcoded English literals while every other toast in the app goes through t()
  • Added vaultActions.fundingWallet, vaultActions.walletFunded, and vaultActions.faucetFailed keys to en.json/fr.json and swapped the hardcoded strings for t() calls

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally

Closes #426

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@Caneryy is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title (feat(meridian): bug-hardcoded-untranslated-toast-strings-in-the-) reads like it got truncated or auto-slugified rather than written out. Please fix it to match your own commit header format, since this repo squash-merges using the PR title as the permanent commit message. Something like fix(web): translate Blend faucet toast messages would work.

The code itself is correct and CI is green, this is purely about the title before merge.

@collinsezedike

Copy link
Copy Markdown
Collaborator

This PR's body doesn't follow CONTRIBUTING.md's PR body format (see "Pull Request Process" > "PR body format").

The Summary section should describe what changed and why, not restate the issue title. The Test plan checkboxes should be checked once you've actually run pnpm lint && pnpm typecheck && pnpm test locally, and the second line should say what you manually verified, not generic placeholder text.

Please update the PR body to reflect what you actually did and verified before this is merged.

@collinsezedike collinsezedike changed the title feat(meridian): bug-hardcoded-untranslated-toast-strings-in-the- fix(web): translate Blend faucet toast messages Jul 30, 2026

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of what was fixed to get this ready:

  • Rebased onto current main, this branch predated the hook-decomposition merge, so useVaultActions.ts's faucet code had since moved to useBlendFaucet.ts. Reapplied the same fix (3 i18n keys, t() calls) against the current file.
  • PR title: fix(web): translate Blend faucet toast messages.
  • PR body: filled in Summary and Test plan properly.

Thank you for the contribution. Feel free to grab another open issue.

Merging now.

@collinsezedike
collinsezedike merged commit e1767f1 into drydocs:main Jul 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Hardcoded untranslated toast strings in the Blend faucet flow

2 participants