fix(web): translate Blend faucet toast messages - #436
Conversation
|
@Caneryy is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
The PR title (feat(meridian): bug-hardcoded-untranslated-toast-strings-in-the-) reads like it got truncated or auto-slugified rather than written out. Please fix it to match your own commit header format, since this repo squash-merges using the PR title as the permanent commit message. Something like fix(web): translate Blend faucet toast messages would work.
The code itself is correct and CI is green, this is purely about the title before merge.
|
This PR's body doesn't follow CONTRIBUTING.md's PR body format (see "Pull Request Process" > "PR body format"). The Summary section should describe what changed and why, not restate the issue title. The Test plan checkboxes should be checked once you've actually run Please update the PR body to reflect what you actually did and verified before this is merged. |
bdf013e to
b181ee9
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
Summary of what was fixed to get this ready:
- Rebased onto current
main, this branch predated the hook-decomposition merge, souseVaultActions.ts's faucet code had since moved touseBlendFaucet.ts. Reapplied the same fix (3 i18n keys,t()calls) against the current file. - PR title:
fix(web): translate Blend faucet toast messages. - PR body: filled in Summary and Test plan properly.
Thank you for the contribution. Feel free to grab another open issue.
Merging now.
Summary
useBlendFaucet.ts's toast strings for the faucet funding flow were hardcoded English literals while every other toast in the app goes throught()vaultActions.fundingWallet,vaultActions.walletFunded, andvaultActions.faucetFailedkeys toen.json/fr.jsonand swapped the hardcoded strings fort()callsTest plan
pnpm lint && pnpm typecheck && pnpm testpass locallyCloses #426