Skip to content

Conversation

@OdenTakashi
Copy link
Contributor

Thanks for maintaining everything 🚀

Problem

When the --nested-position option was enabled and annotating fixture files (yml files) with position_in_fixture: "before", a NoMethodError was raised. This occurred because YmlParser does not have the type_map method, which is required by determine_annotation_position to find the most deeply nested class declaration.

The error occurred at:

parsed.type_map[name] == :class

This was not caught in tests because the integration test had fail_on_error: false, allowing the test to pass even when errors occurred.

Solution

A fallback handling was added to determine_annotation_position for parsers that do not have the type_map method (like YmlParser). When type_map is unavailable, the method falls back to using parsed.starts.first, which is the default behavior for non-nested positioning.

This fix ensures that:

  • Fixture files (yml) can be annotated with nested_position: true without errors
  • When type_map is unavailable, the behavior gracefully falls back to default positioning
  • Ruby files (using CustomParser with type_map) continue to work as expected with nested positioning

Test Coverage

  • Updated the integration test annotate_collapsed_models_nested_position_spec.rb to use fail_on_error: true to catch errors
  • Added the be_successfully_executed assertion to explicitly verify that the command completes without errors
  • The test now properly validates that nested_position works correctly with fixture files

refs: #270

## Problem
When the --nested-position option was enabled and annotating fixture files (yml files) with position_in_fixture: "before", a NoMethodError was raised. This occurred because YmlParser does not have the type_map method, which is required by determine_annotation_position to find the most deeply nested class declaration.

The error occurred at:

```rb
parsed.type_map[name] == :class
```

This was not caught in tests because the integration test had fail_on_error: false, allowing the test to pass even when errors occurred.

## Solution
A fallback handling was added to determine_annotation_position for parsers that do not have the type_map method (like YmlParser). When type_map is unavailable, the method falls back to using parsed.starts.first, which is the default behavior for non-nested positioning.

This fix ensures that:

- Fixture files (yml) can be annotated with nested_position: true without errors
- When type_map is unavailable, the behavior gracefully falls back to default positioning
- Ruby files (using CustomParser with type_map) continue to work as expected with nested positioning

## Test Coverage
- Updated the integration test annotate_collapsed_models_nested_position_spec.rb to use fail_on_error: true to catch errors
- Added the be_successfully_executed assertion to explicitly verify that the command completes without errors
- The test now properly validates that nested_position works correctly with fixture files

refs: drwl#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant