Repository navigation
fix(a11y): skip link, labelled nav, table scope and 320px reflow on the website - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the keyboard/reflow probe on the website:
<main id=main>, labelled main nav.scope=colon headers; the table scrolls inside a labelled, focusable region instead of the page (it overflowed 375px at 320px width); the Guides-only checkbox is a 24px target.scripts/a11y/probe.mjs(tab stops, focus rings, mouse-only controls, skip link, small targets, reflow). Informational, not in CI.axe scan: no violations. Left alone: markdown-generated docs tables have
thwithoutscope(axe accepts them; Hugo has no table render hook), and the web UI's small checkboxes and some 20px text links, which are web UI scope.