Repository navigation
feat(pipeline): mark no-record replies as no_data_held - #165
Merged
Merged
Conversation
Follow-up to #158 review: - Rename the no_data value to no_data_held so it reads as "data held" is false, not "data missing". Unreleased, so no export values change. - MigrateNoData checks its marker read-only first, so routine opens such as `eraser status` don't take the writer lock. - The migration only relabels replies. It no longer resolves requests or completes tasks; ResolveNoData and the reclassify action do that. - responsePreview: drop a redundant EOF branch and match search indexes rune-for-rune so non-ASCII case folding can't drift. - Document the no_data_held triage in docs/broker-replies.md.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up magnus188's #158 (pipeline action alignment, filter repair, no-record reply classification) and applies the review asks from 2026-10-13.
no_datavalue tono_data_held. Unreleased, so no export values change.MigrateNoDatachecks its marker read-only before taking the writer lock.ResolveNoDataand the reclassify action.responsePreview: drop a redundant EOF branch; match search indexes rune-for-rune.docs/broker-replies.md: triage note forno_data_held.Commits keep magnus188's authorship.
go vet ./...andgo test ./...pass locally.