feat: add upstream-level subscription topic filtering#805
Closed
feat: add upstream-level subscription topic filtering#805
Conversation
Allows operators to disable specific eth_subscribe topics (e.g.
newPendingTransactions) per proxy route while keeping others (newHeads,
logs) available.
Config example:
proxy:
routes:
- id: eth
blockchain: ethereum
subscriptions:
disabled:
- newPendingTransactions
- drpc_pendingTransactions
When a client subscribes to a disabled topic, the server returns a
JSON-RPC error -32601 instead of starting the subscription.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tonatoz
force-pushed
the
feature/disable-subscription-topics
branch
from
d14be79 to
3ce902c
Compare
Move subscription filtering from proxy level to upstream level so it
covers all subscription paths: gRPC (NativeSubscribe), WebSocket proxy,
Describe, and cascading dshackle-to-dshackle subscriptions.
Config example:
cluster:
upstreams:
- id: local
chain: ethereum
subscriptions:
disabled:
- newPendingTransactions
- drpc_pendingTransactions
Disabled topics are aggregated (union) across all upstreams in a
multistream. The filter applies in both getAvailableTopics() (blocks
gRPC guard + Describe) and subscribe() (blocks WS proxy path).
Reverts the previous proxy-level approach as it only covered the
WebSocket proxy path.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tonatoz
changed the title
Pass emptySet() for the new disabledSubscriptions parameter when constructing GenericUpstream directly from Groovy test code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscriptions.disabledconfig option at the upstream level (UpstreamsConfig.Upstream) to disable specific subscription topicsgetAvailableTopics()andsubscribe()— covers all subscription pathsCoverage Matrix
NativeSubscribe.start()viagetAvailableTopics()EthereumEgressSubscription.subscribe()getAvailableTopics()start()before proxyingConfig example