Mapping of common attribute now keeps the initial fields#5
Open
Dlacreme wants to merge 2 commits intodropbox:mainfrom
Open
Mapping of common attribute now keeps the initial fields#5Dlacreme wants to merge 2 commits intodropbox:mainfrom
Dlacreme wants to merge 2 commits intodropbox:mainfrom
Conversation
|
|
FelixFortis
pushed a commit
to jobteaser/esaml
that referenced
this pull request
Jan 12, 2026
feat: Always return attribute values as lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapping done by esaml works well but does not add the initial fields to the result. This PR solves the matter by keeping all the data sent by the IDPs. This helped us to provide helpful logs for debugging and clearly improve maintainability.
From our test, this has no impact on the current implementation. While I don't expect a direct merge, I hope to gather some of your feedbacks/ideas.
Before this change:
After this change: