Skip to content

Remove problematic Chinese test file - #2668

Open
abhinavprakash-x wants to merge 1 commit into
drogonframework:masterfrom
abhinavprakash-x:bugfix/2449-remove-chinese-txt
Open

abhinavprakash-x wants to merge 1 commit into
drogonframework:masterfrom
abhinavprakash-x:bugfix/2449-remove-chinese-txt

Conversation

@abhinavprakash-x

Copy link
Copy Markdown

Description

Removes lib/tests/integration_test/server/中文.txt as requested in issue #2449.

This file causes compilation issues on Windows.

Testing

  • Successfully configured Drogon using CMake on Ubuntu (WSL).
  • Successfully built Drogon, drogon_ctl, and the configured examples using GCC.

Closes #2449

@abhinavprakash-x

Copy link
Copy Markdown
Author

While checking the references to 中文.txt, I noticed that it is also used in the integration tests:

  • lib/tests/integration_test/client/main.cc uses it to test serving files with non-ASCII filenames.
  • The same file uses it in an UploadFile test.
  • lib/tests/CMakeLists.txt copies it into the integration-test server directory.

Should I remove these test usages as part of this issue, or would you prefer that I preserve the non-ASCII filename test coverage using a different approach?

I want to make sure removing the fixture doesn't unintentionally break the integration tests or reduce existing test coverage.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please delete the file "中文.txt"

1 participant