Skip to content

Release HttpClient on its loop after a DNS lookup #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StevSoested wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Release HttpClient on its loop after a DNS lookup #2667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/src/HttpClientImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,13 @@ void HttpClientImpl::sendRequestInLoop(const drogon::HttpRequestPtr &req,
}
auto thisPtr = shared_from_this();
resolverPtr_->resolve(
domain_, [thisPtr](const trantor::InetAddress &addr) {
thisPtr->loop_->runInLoop([thisPtr, addr]() {
domain_, [thisPtr](const trantor::InetAddress &addr) mutable {
// The resolver may call back on a thread of its own and
// destroy this callback there. Move the client to its loop,
// so that its last reference is never dropped elsewhere:
// ~HttpClientImpl() would then use a loop that may be gone.
auto loop = thisPtr->loop_;
loop->runInLoop([thisPtr = std::move(thisPtr), addr]() {
// Retrieve port from old serverAddr_
auto port = thisPtr->serverAddr_.portNetEndian();
thisPtr->serverAddr_ = addr;
Expand Down
Loading