Repository navigation
repair chunk size overflowing in parser - #2650
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the chunk-length overflow guard.
No open issues 🎉
What changed in this PR
This PR hardens HTTP response chunk parsing by rejecting chunk lengths that would overflow when adding the two-byte trailing delimiter.
Changes:
- Adds a
size_tupper-bound check alongside existing chunk-length validation. - Includes
<limits>to obtain the platform-specific maximum value.
| File | Description |
|---|---|
lib/src/HttpResponseParser.cc |
Rejects chunk lengths greater than SIZE_MAX - 2 to prevent overflow in subsequent buffer checks. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
chunk-lengthis set toSIZE_MAX - 2,strtoullpasses. But later in line 286,currentChunkLength_ + 2overflows to 0,if(buf->readableBytes() >= (currentChunkLength_ + 2))passes and access underneath overflows. This patch ensures that overflow is impossible.