Repository navigation
Conversation
When Content-Type ends exactly at "boundary=" with no value after it, pos equals contentType.size() after the offset advance. The subsequent contentType[pos] access reads one byte past the string, causing undefined behavior (OOB read). Add a pos >= contentType.size() guard that marks the parser invalid and returns early, consistent with the other missing-boundary check above it. Fixes the remaining issue from GHSA-hv4q-wjv9-x524 (bug 1 of 3).
Contributor
Author
|
Closing -- submitted to wrong branch. Will resubmit to the correct location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Content-Typeends exactly atboundary=with no value,posequalscontentType.size()after the offset advance. The subsequentcontentType[pos]access at line 44 reads one byte past the string (OOB).Adds a
pos >= contentType.size()guard that marks the parser invalid and returns early.Fixes the remaining bug (1 of 3) from GHSA-hv4q-wjv9-x524. Bugs 2 and 3 were fixed in #2625.