Support orcid accounts#14
Open
jtourkos wants to merge 4 commits into
Open
Conversation
Resolves: #13
|
🚅 Environment sprinkler-pr-14 in Drips App has no services deployed. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ORCID accounts by implementing a new processing pipeline alongside the existing drip lists and projects processing. The changes introduce ORCID account validation, contract interaction capabilities, and database schema updates to support the new functionality.
- Adds ORCID account processing with validation logic to ensure accounts split 100% to their owners
- Introduces repo sub-account driver contract integration for calculating sub-project account IDs
- Updates database queries to use new snake_case table naming convention
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Adds repoSubAccountDriver contract address to Network type |
| src/queries/getTokens.ts | Updates table names from PascalCase to snake_case |
| src/queries/getCurrentSplitsReceivers.ts | Simplifies splits receiver query logic and updates schema |
| src/queries/getAllProjectsSortedByCreationDate.ts | Adds sub-project calculation and renames function |
| src/queries/getAllOrcidAccountsWithSplits.ts | New query for retrieving ORCID accounts with splits data |
| src/queries/getAllDripListsSortedByCreationDate.ts | Updates table name to snake_case |
| src/index.ts | Integrates ORCID processing into main workflow |
| src/getNetwork.ts | Adds repoSubAccountDriver contract addresses |
| src/contracts/unwrapEthersResult.ts | Utility for unwrapping ethers contract results |
| src/contracts/repoSubAccountDriverAbi.ts | ABI definition for repo sub-account driver contract |
| src/contracts/repoSubAccountDriver.ts | Contract interaction wrapper |
| src/contracts/drips-client.ts | Refactors to use shared unwrap utility |
efstajas
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.