Repository navigation
fix(billing): prevent Plus demotion on duplicate checkout expiry - #28
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
beginCheckout must not overwrite active_plus or grace_period with checkout_pending. When an abandoned checkout session expires, restore the subscription from authoritative entitlement state instead of downgrading paying customers to free. Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: drferdiiskandar <drferdiiskandar@sentrahai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 8, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
An workspace already on Plus (
active_plus) could callPOST /v1/billing/checkout.beginCheckoutunconditionally setsubscription.statetocheckout_pending. When that second Xendit session expired,applyVerifiedPaymentEventtreated it like an abandoned first-time checkout and downgraded the workspace to free, revoking Plus without a real renewal failure.Root cause
beginCheckoutfor existing paid states.checkout_pending→freeon expiry, but did not consider entitlement/subscription desync when checkout was opened on top of an active subscription.Fix
active_plusorgrace_period(409).renewal_failedwithcheckout_pending, if entitlement is stillactive_plusorgrace_period, restore the subscription row from entitlement instead of downgrading to free.Validation
vitest run packages/db/src/platform.test.ts— 15 passed (includes new regression tests).