fix(billing): avoid grace period on abandoned checkout expiry - #13
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
When Xendit sends payment_session.expired for a checkout that was never paid, applyVerifiedPaymentEvent now reverts checkout_pending workspaces back to free instead of entering grace_period. Grace period is reserved for active_plus renewal failures only. Co-authored-by: drferdiiskandar <drferdiiskandar@sentrahai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When a user starts a Plus checkout (
checkout_pending) but abandons the QRIS session, Xendit sendspayment_session.expired. The webhook mapped this torenewal_failed, andapplyVerifiedPaymentEventunconditionally moved the workspace intograce_periodwith downgraded entitlements — even though the user never paid.Impact: Incorrect billing state (
plus/grace_periodvsfree/free), spurious entitlement downgrades, and divergence from the subscription state machine inplatform-policy.ts.Root cause
applyVerifiedPaymentEventtreated everyrenewal_failedlifecycle the same, without checking whether the workspace was incheckout_pendingvsactive_plus.Fix
checkout_pending+ expired → revert tofree(no grace period).active_plus+ renewal failure → entergrace_period(unchanged intent).Validation
packages/db/src/platform.test.tsfor abandoned checkout and active renewal failure paths.apps/api/src/xendit-webhook.test.ts.pnpm exec vitest run packages/db/src/platform.test.ts apps/api/src/xendit-webhook.test.ts— 16/16 passed.