Repository navigation
Conversation
lriggs
force-pushed
the
gandiva-lazy-bitcode-link
branch
from
November 14, 2026 01:06
465ac88 to
17c3926
Compare
Gandiva links its entire precompiled bitcode library (~1600 functions) into every expression module and then relies on Internalize + global DCE to strip the unused ones. That link-and-prune runs on every uncached compile and is a large fixed cost independent of the expression. Instead, parse the precompiled module lazily and add only *declarations* for its functions to the module up front; then at FinalizeModule use llvm::Linker::LinkOnlyNeeded to pull in just the function bodies the generated code actually references (and their dependencies), dropping declarations that went unused. No change to generated code or results; this only reduces per-compile linking work. Cuts the fixed compile floor substantially on cold compiles.
lriggs
force-pushed
the
gandiva-lazy-bitcode-link
branch
from
November 14, 2026 01:15
17c3926 to
ef89f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gandiva links its entire precompiled bitcode library (~1600 functions) into every expression module and then relies on Internalize + global DCE to strip the unused ones. That link-and-prune runs on every uncached compile and is a large fixed cost independent of the expression.
Instead, parse the precompiled module lazily and add only declarations for its functions to the module up front; then at FinalizeModule use llvm::Linker::LinkOnlyNeeded to pull in just the function bodies the generated code actually references (and their dependencies), dropping declarations that went unused.
No change to generated code or results; this only reduces per-compile linking work. Cuts the fixed compile floor substantially on cold compiles.