Repository navigation
Conversation
lriggs
force-pushed
the
gandiva-cache-key-config-equality
branch
from
November 14, 2026 01:06
7f3bf61 to
c8864ff
Compare
…n cache key ExpressionCacheKey::Hash() folds in configuration->Hash() by content, but operator== compared the configuration shared_ptr by identity. Two distinct Configuration instances with identical content therefore hashed equal yet compared unequal, so the compiled-expression cache missed and Gandiva recompiled an expression it had already built. Performance bug only (never a wrong result); impact scales with how often callers build fresh Configuration objects rather than sharing one. Compare *configuration_ by value (Configuration::operator== already exists), with a null-safe guard. Adds TestExpressionCacheKeyConfigByValue.
lriggs
force-pushed
the
gandiva-cache-key-config-equality
branch
from
November 14, 2026 01:15
c8864ff to
91c9db3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n cache key
ExpressionCacheKey::Hash() folds in configuration->Hash() by content, but operator== compared the configuration shared_ptr by identity. Two distinct Configuration instances with identical content therefore hashed equal yet compared unequal, so the compiled-expression cache missed and Gandiva recompiled an expression it had already built. Performance bug only (never a wrong result); impact scales with how often callers build fresh Configuration objects rather than sharing one.
Compare *configuration_ by value (Configuration::operator== already exists), with a null-safe guard. Adds TestExpressionCacheKeyConfigByValue.