Skip to content

DX-128210: Cache arena used pointer in generated Gandiva functions (apache/arrow#55282 follow-up) to dremio_27.0_23_19 - #153

Merged
lriggs merged 1 commit into
dremio:dremio_27.0_23_19from
victor6567758:DX-128210-arrow-55282-arena-ptr-dremio_27.0_23_19
Nov 12, 2026
Merged

lriggs merged 1 commit into
dremio:dremio_27.0_23_19from
victor6567758:DX-128210-arrow-55282-arena-ptr-dremio_27.0_23_19

Conversation

@victor6567758

@victor6567758 victor6567758 commented Nov 11, 2026 •

Copy link
Copy Markdown

What's Changed

Follow-up to #149 / #150. Cherry-pick of the fifth commit of apache/arrow#55282, 78afa85984 "apacheGH-55281: [C++][Gandiva] Cache arena used pointer in generated functions" (Dmitry Chirkov), onto dremio_27.0_23_19.

Generated code no longer reads the arena "used" flag at a byte offset from the ExecutionContext pointer. It calls the new gdv_fn_context_arena_used_ptr once per generated function and caches the pointer. This is an optimization, not a behaviour change, and it removes the dependency on the ExecutionContext layout.

Files: cpp/src/gandiva/context_helper.cc, execution_context.h, gdv_function_stubs.h, llvm_generator.cc, tests/projector_test.cc.

Backport notes

  • Applied with git cherry-pick -x, no conflicts. Upstream author and the (cherry picked from commit ...) trailer are preserved.

Testing

  • gandiva-projector-test --gtest_filter=TestProjector.TestLevenshteinArenaGrowth:TestProjector.TestNestedStringFunctionArenaGrowth:TestProjector.TestExtendedCFunctionArenaGrowth passes on this branch
  • git range-diff pr-55282~1..pr-55282 origin/dremio_27.0_23_19..DX-128210-arrow-55282-arena-ptr-dremio_27.0_23_19
  • arrow-java jarBuild is ok: https://github.com/dremio/arrow-java/actions/runs/43071362250

DX-128210

… generated functions

(cherry picked from commit 78afa85)
@victor6567758
victor6567758 marked this pull request as ready for review November 11, 2026 22:01
@lriggs
lriggs merged commit 21ae2ed into dremio:dremio_27.0_23_19 Nov 12, 2026
18 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants