Repository navigation
DX-128210: Cache arena used pointer in generated Gandiva functions (apache/arrow#55282 follow-up) to dremio_27.0_23_19 - #153
Merged
lriggs merged 1 commit intoNov 12, 2026
Conversation
… generated functions (cherry picked from commit 78afa85)
victor6567758
requested review from
akravchukdremio,
dmitry-chirkov-dremio,
lriggs and
xxlaykxx
November 11, 2026 17:22
lriggs
approved these changes
Nov 11, 2026
victor6567758
marked this pull request as ready for review
November 11, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Follow-up to #149 / #150. Cherry-pick of the fifth commit of apache/arrow#55282,
78afa85984"apacheGH-55281: [C++][Gandiva] Cache arena used pointer in generated functions" (Dmitry Chirkov), ontodremio_27.0_23_19.Generated code no longer reads the arena "used" flag at a byte offset from the
ExecutionContextpointer. It calls the newgdv_fn_context_arena_used_ptronce per generated function and caches the pointer. This is an optimization, not a behaviour change, and it removes the dependency on theExecutionContextlayout.Files:
cpp/src/gandiva/context_helper.cc,execution_context.h,gdv_function_stubs.h,llvm_generator.cc,tests/projector_test.cc.Backport notes
git cherry-pick -x, no conflicts. Upstream author and the(cherry picked from commit ...)trailer are preserved.Testing
gandiva-projector-test --gtest_filter=TestProjector.TestLevenshteinArenaGrowth:TestProjector.TestNestedStringFunctionArenaGrowth:TestProjector.TestExtendedCFunctionArenaGrowthpasses on this branchgit range-diff pr-55282~1..pr-55282 origin/dremio_27.0_23_19..DX-128210-arrow-55282-arena-ptr-dremio_27.0_23_19arrow-javajarBuildis ok:https://github.com/dremio/arrow-java/actions/runs/43071362250DX-128210