Repository navigation
DX-126900: [Java][Gandiva] Report time64 types as TIME64 in the expression registry - #35
Merged
akravchukdremio merged 1 commit intoNov 4, 2026
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
expression_registry_helper.ccmappedarrow::Type::TIME64toGandivaType::TIME32. Java therefore sawTime(MICROSECOND, 32)/Time(NANOSECOND, 32)inExpressionRegistry.getSupportedTypes()and in function signatures. It could never match the real 64-bitTIME(6)/TIME(9)types Dremio uses. This blocks Gandiva pushdown of the new time64 functions from dremio/arrow#146. Jira: https://dremio.atlassian.net/browse/DX-126900What changes are included in this PR?
TIME64→GandivaType::TIME64.ExpressionRegistryTest:testTimeTypesKeepBitWidthasserts Time32/Time64 are reported with the correct widths.testTime64Functionsasserts time64 signatures (extractHour,less_than,isnull) are visible from Java. This test requires the Gandiva C++ from DX-126900: [C++][Gandiva] Add TimeIR for unit-aware time64[us/ns] support arrow#146.Are these changes tested?
Yes. After rebasing onto the latest
dremio_27.0_23_19(includes #33), I ran the full Gandiva Java suite locally with JNI built against dremio/arrow#146: 95 tests, 0 failures. That includesExpressionRegistryTest(6),ProjectorTest(44) andFilterTest(7).Test jar build from this branch + dremio/arrow#146, used by dremio/dremio#29364:
custom-arrow-gandiva-build: https://jenkins.drem.io/job/custom-arrow-gandiva-build/1590/19.1.0-20261026101537-a9ab9ad-b00d126-dremioAre there any user-facing changes?
Time64 types and functions are now reported correctly by the Gandiva expression registry.
Merge after dremio/arrow#146.
🤖 Generated with Claude Code