Skip to content

DX-126900: [Java][Gandiva] Report time64 types as TIME64 in the expression registry - #35

Merged
akravchukdremio merged 1 commit into
dremio:dremio_27.0_23_19from
akravchukdremio:DX-126900-gandiva-time64
Nov 4, 2026
Merged

akravchukdremio merged 1 commit into
dremio:dremio_27.0_23_19from
akravchukdremio:DX-126900-gandiva-time64

Conversation

@akravchukdremio

@akravchukdremio akravchukdremio commented Oct 3, 2026 •

Copy link
Copy Markdown

Rationale for this change

expression_registry_helper.cc mapped arrow::Type::TIME64 to GandivaType::TIME32. Java therefore saw Time(MICROSECOND, 32) / Time(NANOSECOND, 32) in ExpressionRegistry.getSupportedTypes() and in function signatures. It could never match the real 64-bit TIME(6) / TIME(9) types Dremio uses. This blocks Gandiva pushdown of the new time64 functions from dremio/arrow#146. Jira: https://dremio.atlassian.net/browse/DX-126900

What changes are included in this PR?

Are these changes tested?

Yes. After rebasing onto the latest dremio_27.0_23_19 (includes #33), I ran the full Gandiva Java suite locally with JNI built against dremio/arrow#146: 95 tests, 0 failures. That includes ExpressionRegistryTest (6), ProjectorTest (44) and FilterTest (7).

Test jar build from this branch + dremio/arrow#146, used by dremio/dremio#29364:

Are there any user-facing changes?

Time64 types and functions are now reported correctly by the Gandiva expression registry.

Merge after dremio/arrow#146.

🤖 Generated with Claude Code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

Couldn't load assignees.