Repository navigation
fix(compare): wait for the sheet scroll service before scroll sync - #58
Merged
Merged
Conversation
A peer scroll can run before SheetScrollManagerService is registered. That throw unmounts the comparison view. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SheetScrollManagerServicebefore callingsheet.operation.set-scroll.univer-clicopy of the same guard already opened for the DSH plugin.Test plan
pnpm --filter @univer/unit-comparison-viewer exec vitest run test/readonly-workbook-scroll.test.tsxpnpm --filter @univer/unit-comparison-viewer exec tsc -p tsconfig.test.json --noEmitMade with Cursor