Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions benches/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,26 @@ fn key_heavy_json_value(b: &mut Bencher) {
bench_value(b, &get_key_heavy_json());
}

// struct deserialization matches keys against static field names, so borrowed
// keys avoid the per-property allocation entirely (unlike a serde_json::Value
// target, whose Map must own its keys regardless)
#[bench]
#[cfg(feature = "serde")]
fn key_heavy_json_serde_struct(b: &mut Bencher) {
#[derive(serde::Deserialize)]
#[allow(dead_code)]
struct Item {
id: u32,
name: String,
kind: String,
enabled: bool,
count: u32,
tag: String,
}
let json = get_key_heavy_json();
b.iter(|| jsonc_parser::parse_to_serde_value::<Vec<Item>>(&json, &Default::default()).unwrap());
}

#[bench]
fn tsconfig_json_ast(b: &mut Bencher) {
bench_ast(b, &get_tsconfig_json());
Expand Down
7 changes: 5 additions & 2 deletions src/serde.rs
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,12 @@ impl<'de, 'b> MapAccess<'de> for ScannerMapAccess<'de, 'b> {
match key {
None => Ok(None),
Some(key) => {
let key_str = key.into_string();
// borrow the key from the source when it's clean, only allocating for
// owned (escaped) keys — mirrors the value path's `Cow` keys
seed
.deserialize(<String as IntoDeserializer<Self::Error>>::into_deserializer(key_str))
.deserialize(<Cow<'de, str> as IntoDeserializer<Self::Error>>::into_deserializer(
key.into_cow(),
))
.map(Some)
}
}
Expand Down
Loading