Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11, though not in the same way I described in the issue. It still achieves the objective of enabling tool calls to be multi-threaded.
Difference is that instead of having the application decide on the concurrency mechanism for server state, it just uses
MVar. This does make things a little awkward for theStdioimplementation which is usingIORef.I'm not sure how to resolve that other than creating some sort of abstraction overUPDATE: I switched it toMVarandIORefor by switching the entireStdioimplementation to usingMVar.MVarsince it's more capable thanIOReffor concurrency, and you might want tool handlers to spin new threads that modify server state.Some awkwardness is also removed as the current authenticated user is now separated from server state.
This is a breaking change.