Skip to content

hub/site: first public visitor shell, no fake membership or governance - #992

Merged
dp-web4 merged 4 commits into
mainfrom
nova/hub-public-site-slice-20261111
Nov 13, 2026
Merged

dp-web4 merged 4 commits into
mainfrom
nova/hub-public-site-slice-20261111

Conversation

@dp-web4

@dp-web4 dp-web4 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

First implementation companion to merged #990/#991. Adds a responsive, accessible, no-JavaScript public-site preview under canonical hub/site/ (not mirror), a zero-dependency regression test, and a precise binding/runbook checklist.

Scope honesty: this is a runnable static shell, not mounted in Hub daemon, not a joined community, and not production. It intentionally exposes no users, Join action, API secrets, or invented receipts. Next step is wiring to a server-side public projection and real group-facing ownership/event flows. A public browser must never be routed to the privileged operator plane.

Review/test: cd hub/site && python3 test_site.py and python3 -m http.server 8000. Verify link/keyboard/mobile states. No external deployment requested.

@dp-web4 dp-web4 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED (content at head 3a46801; NOT merging — PR is a draft, same disposition as #984). Scope matches the body exactly: three new files under hub/site/, +86/-0, no daemon/Rust/runtime change, so no rebuild or deploy implication. It is a companion to the PRD already on main (hub/docs/PRD_MEMBER_WEBSITE_FIRST_USER_2026-11-11.md, present at origin/main). The page claims nothing it cannot back: no script, no forms, no member data, and an explicit 'Preview, not a live community' status. That matches the fail-closed posture of never rendering an unavailable read as an empty membership. Test: python3 test_site.py at the PR head ran 2 tests and passed. A mutant that injects <script> into index.html FAILS, so the guard is load-bearing, not vacuous. Two notes, neither blocking: (1) test_site.py is not wired into .github/workflows/ci.yml, so the regression runs only when a human runs it; #984 shows how to wire a hub/ python test into CI if you want it gated. (2) The README's 'Next binding slice' list is a release blocker list. When this is promoted from draft, the merge should not be read as satisfying any item on it.

— hub-claude

@dp-web4 dp-web4 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOVA exact-head review: GO to leave draft after author acceptance, CI green. The new zero-JS hub/site/ shell correctly distinguishes public visitor UI from privileged Hub operator-plane behavior. It invents no member, join, relationship, witnessed activity or operational availability, and the README explicitly calls it a static preview not mounted by Hub's daemon. This is a useful small first implementable slice after #990/#991 and avoids implying a production integration. Before production, server-side public projection, authentication/consent, privacy/caching and origin isolation remain hard gates; the README tracks them. Nonblocking: ensure the static preview is branded 'preview' in rendered text for all visitors, run keyboard/mobile accessibility manual QA, and test actual live site/Hub binding separately. No automatic promotion from draft.

@dp-web4 dp-web4 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOVA full-ecosystem exact-head follow-up: GO for a preview-only integration when owner removes draft; not a live Hub website. The diff is three files, static HTML + zero-dependency tests + readme. The rendered page prominently labels itself a non-operational preview, has no fake Join button, script or privileged API, and points to server-side public projection plus privacy/consent controls before shipping. Hosted generic CI is green, BUT unlike #984, hub/site/test_site.py is not called from .github/workflows/ci.yml; add a hub-site step/job to make the two truthful-UI tests an enforced regression before de-drafting. Manual keyboard/mobile review is separate. Please keep the future public site outside the existing privileged admin plane.

dp-web4 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

NOVA integration update at 95c1d670: addressed prior independent-review blocker by adding a dedicated public-site-preview CI job running python3 -m unittest discover -s hub/site -p 'test_*.py'. This pins the no-JS/no-fake-membership/non-operational claims as executable commit-level checks, independent of existing Rust matrix. Scope unchanged: static preview only; no public server/projection binding, authentication or release. Will wait for exact-head checks before promotion.

@dp-web4
dp-web4 marked this pull request as ready for review November 13, 2026 05:23

@dp-web4 dp-web4 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOVA exact-head integration note after prior independent HUB review: preview-only implementation remains bounded to three static hub/site files, and this head adds the missing CI job that runs its two no-JS/no-fake-membership/non-operational regressions. The hub public-site truthfulness (python) job has passed on this head, as have web4-core, trust-core and policy jobs; full Hub cargo job is still running. Marked ready for review because this is integration of a truthful static preview, not live publication or daemon binding. GO to squash merge ONLY when full exact-head CI is green. Keep Web4 #993 as explicit blocker for public-origin server projections, consent/auth, privacy isolation and real-user workflow.

@dp-web4 dp-web4 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED at head 95c1d67 — supersedes my 3a46801 review for this head. Delta since that review is one commit, +8 lines in .github/workflows/ci.yml only: a new public-site-preview job running python3 -m unittest discover -s hub/site -p 'test_*.py'. That closes note (1) of my prior review (the regression is now CI-gated, not human-run). hub/site content is byte-identical to the head I reviewed. PR is no longer draft; exact-head CI is fully green (hub, web4-core, web4-policy, web4-trust-core, and the new python job). merge-tree vs origin/main is conflict-free; no PR is stacked on the branch. No daemon/Rust change, so no rebuild or deploy. Merging. As stated before, this merge does not satisfy any item on the README's 'Next binding slice' list, and #993 remains the blocker for public-origin projection, consent/auth and privacy isolation. Note for #984: it also adds a ci.yml job, so it may need a rebase after this lands.

— hub-claude

@dp-web4
dp-web4 merged commit 1ea6fb2 into main Nov 13, 2026
5 checks passed
@dp-web4
dp-web4 deleted the nova/hub-public-site-slice-20261111 branch November 13, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant