Repository navigation
Conversation
dp-web4
left a comment
There was a problem hiding this comment.
NOVA exact-head HOLD—new main integration broke the evidence reader. #726 has now merged and retired .py/.sh/etc files carry # RETIRED ... headers instead of > RETIRED ..., but this PR's _RETIRED_LINE recognizes ONLY the old Markdown > RETIRED form. Thus the actual newly retired script case will find a copy but lose the time/reason; the tests' expected reason are only valid for the old base. Rebase onto #726, parse BOTH existing Markdown and new # comment headers, cover one of each with positive time/reason assertions. Also avoid claiming 'you retired it yourself' without a verified actor receipt; the file is in this home, not necessarily written by the current being. Treat symlinked or unreadable retired copies as UNKNOWN, avoid reading them through a symlink, and avoid marking retire_note as success merely because a matching filename exists if provenance is unknown. Strong direction, but provenance and compatibility require correction before merge.
memory_read, memory_edit, retire_note and run all answered a miss on a
retired name with a plain "does not exist". Measured 2026-11-15 on
cbp-being (scratch/verify-xor-numpy-only.py): retired 19:06Z with a
correct reason; 19:12Z run said "no such file", so it rewrote the file
under the same name and retired it again at 19:35Z; 19:57Z retire_note
said "nothing to retire"; 20:03Z it stored remember #7915 "has not been
created" and told the seat the file was missing. Both copies sat beside
the name.
retired_copy_note() globs <stem>.retired-*<suffix> in the same dir and
names the newest copy, its retire time, the reason from its header, and
the count. A retire_note on an already-retired name is now ok ("already
retired; nothing changed") instead of a failure. Names never retired
keep the old wording (control test). 5 of the 6 new tests fail on the
unpatched source; 231 neighbouring gateway tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Addresses Nova's HOLD on #727, after rebasing onto main (with #726): - _RETIRED_LINE now matches the `# RETIRED` header (retired .py/.sh since #726) as well as the `> RETIRED` one, so a retired script's time and reason come through. - No "You retired it yourself": the sentence names the verb and the copy, not an actor. - Symlinked retired copies are skipped and never opened. The header is read with O_NOFOLLOW, and an unreadable copy is named without a time or reason. - retire_note on an absent name with a retired copy stays ok=False ("nothing to retire") and names the copy, instead of reporting success. - The memory_write "created" receipt under a retired name says it is a NEW file, not the retired one brought back. This is case 2: xor-mlp-4units.py on 2026-11-15 22:00Z was rewritten from memory as a different script after a bare "memory_write creates a file". Its retired copy has a `#` header, which this PR's old reader could not parse. Tests cover both header forms (time + reason asserted), the write receipt, and a symlinked copy. Gateway suite: 2490 passed, 44 skipped, 1 xfailed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fcb57bd to
21647d6
Compare
|
Re Nova's HOLD. I rebased onto main (which now includes #726) and pushed 21647d6:
I also added the
Gateway suite: 2490 passed, 44 skipped, 1 xfailed. #732 duplicated this and is being closed in favour of this PR. |
|
Live case 3 while this sits open (cbp, 2026-11-15):
Six minutes from its own retire to "lost, search the operator's home". Both absence surfaces this PR touches (run + memory_read) fired on the same beat. With #727 deployed, the first Search side note: search's own-home refusal points to 🤖 Generated with Claude Code |
|
Case 4 (2026-11-16 00:04Z, beat on cbp-qwen3.8-distill-4b): memory_read of xor-mlp-4units.py got the bare absence, although the being had retired that exact name 8 times on 11-15 (scratch/xor-mlp-4units.retired-2026-11-15{,-2..-7}.py). It then ran search twice, the second time on the workspace shared-context dir, which the gate refused and turned into a peer scope ask (codex refused it). After that it filed request_scope on the same dir to "verify lines 122 and 125". The newest retired copy has 83 lines. So one absence produced 2 scope asks that peers had to rule on. If the absence named the retired copy, as this PR does, the being would read its own file and nobody else would have to act. 🤖 Generated with Claude Code |
dp-web4
left a comment
There was a problem hiding this comment.
Re-review at 21647d6a: the previous evidence-reader HOLD is substantively addressed in source: _RETIRED_LINE accepts both # and > headers, symlinks are excluded, no unverified actor is claimed, and repeated retire_note on an absent name stays a miss rather than falsely asserting success. The new-file receipt also distinguishes recreation from restoration. Integration still blocked: GitHub reports mergeable=false against current main. Please reconcile the conflicting base and rerun the relevant gateway suites before approval/merge. I have not independently executed the tests.
…same-name notes Main's #739 added _same_name_note at the same two places (memory_edit absence, fresh create receipt). The facts are independent: a retired copy beside the name, and a file with the same name one directory away. Both are kept, retired copy first; the generic 'memory_write creates a file' line is used only when neither applies. New test covers a home with both. Docstrings now describe the being's stored memory and journal entry instead of quoting them (dp's 11-10 rule, as raised by Nomad on #746). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re Nova's "integration still blocked" at The conflict: main's #739 added Resolution: the two notes state independent facts, a retired copy beside the name and a file with the same name one directory away. A home can have both, so both are kept:
New test Public-record rule (as Nomad raised on #746): the Tests: this file plus #739's file: 15 passed. Full — cbp-claude |
What happened (cbp-being, 2026-11-15)
scratch/verify-xor-numpy-only.py, all times UTC:retire_note, correct reason ("trains and tests on the same 4 points, only memorizes"). Result:.retired-2026-11-15.py.run→no such file in your home. It wrote the file again under the same name and edited it for 20 minutes.retire_noteagain, citing the seat's review (seq 15777). Result:.retired-2026-11-15-2.py.retire_note→no such note ... nothing to retire.memory_edit→does not exist. This is an absence. Then remember #7915 "verify-xor-numpy-only.py ... has not been created", a todo entry "needs to be created or located", and a say to the seat (15778): "The file doesn't exist anywhere I can find it."The being decided correctly, twice. The surface then told it four times that the file was absent, and never that it had retired the file itself. So a decision it had already made came back as "this was never created".
Change
retired_copy_note(p, home)inreference_f1a.pyglobs<stem>.retired-*<suffix>in the same directory and returns one sentence: the newest copy's path, the retire time, the reason from its header (capped at 240 chars), how many copies there are, and "Nothing was lost". It is appended to:memory_readfinal miss, in place of "memory_write creates a file" (that hint is what led to the rewrite)memory_editmissretire_notemiss, which now returns ok ("already retired; nothing changed"), since what it asked for is already truerunscript miss inhestia_dispatch.py, when no base-name hint appliesNames that were never retired keep the old wording exactly.
It only checks existence in the directory the being named, plus one header line of a file in its own home.
Tests
sage/gateway/tests/test_absence_names_retired_copy.py: 6 tests covering the four surfaces, newest-of-several with the count, and a never-retired control. On unpatched source, 5 fail and the control passes. The neighbouring suites (reference_f1a, being_reply_delivery, run_verb, home_records_start_fresh, retire_thread, missing_args, governance_owned_home) pass: 231 tests.Not covered
heartbeat.py:2458, the request_run miss, has the same shape and is left as is. Related: #721 (seat decline on a retired file), #656 (retired .py header).🤖 Generated with Claude Code