fix: skip DOMDocumentType when importing XML with DOCTYPE declaration#71
Open
guillaumedelre wants to merge 1 commit into
Open
fix: skip DOMDocumentType when importing XML with DOCTYPE declaration#71guillaumedelre wants to merge 1 commit into
guillaumedelre wants to merge 1 commit into
Conversation
DOMDocument::importNode() returns false for DOMDocumentType nodes, causing appendChild() to receive a boolean and throw a fatal error. This happens when loading or inserting XML that contains a <!DOCTYPE> declaration: the node list from childNodes includes the DOMDocumentType node alongside the root element. Skip DOMDocumentType entries in attachNodes() before attempting the import, so the document content is imported correctly and the DOCTYPE declaration is silently discarded. Fixes downforcetech#44 Fixes downforcetech#50 Signed-off-by: Guillaume Delré <delre.guillaume@gmail.com>
Author
|
Hey @daniele-orlando, this PR fixes #44 and #50 — happy to adjust if anything looks off. |
Author
|
Hey @daniele-orlando, gentle ping on this one. Let me know if you'd prefer a different fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOMDocument::importNode() returns false for DOMDocumentType nodes, causing appendChild() to receive a boolean and throw a fatal error.
This happens when loading or inserting XML that contains a <!DOCTYPE> declaration: the node list from childNodes includes the DOMDocumentType node alongside the root element.
Skip DOMDocumentType entries in attachNodes() before attempting the import, so the document content is imported correctly and the DOCTYPE declaration is silently discarded.
Fixes #44
Fixes #50