fix: escape XML special characters in addChild text content#67
Open
guillaumedelre wants to merge 1 commit into
Open
fix: escape XML special characters in addChild text content#67guillaumedelre wants to merge 1 commit into
guillaumedelre wants to merge 1 commit into
Conversation
DOMElement::__construct does not escape & or < in its value argument, causing DOMException when user data contains XML special characters. Replace the value parameter with a createTextNode call after attachment, which handles escaping at the DOM level. Fixes downforcetech#14 Signed-off-by: Guillaume Delré <delre.guillaume@gmail.com>
Author
|
Hey @daniele-orlando, this PR fixes #14 — happy to adjust if anything looks off. |
Author
|
Hey @daniele-orlando, just a gentle ping on this one. Happy to rebase or adjust if needed. |
Member
|
Hi @guillaumedelre, thanks for your valuable pull requests. I'm committed to review and merge them in the codebase as soon as I find a slot of time to work on fluidxml. Don't worry in case they remain parked for few days, I'll not forget about them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOMElement::__construct does not escape & or < in its value argument, causing DOMException when user data contains XML special characters. Replace the value parameter with a createTextNode call after attachment, which handles escaping at the DOM level.
Fixes #14