doc: record the "a harness must not delete its own evidence" rule - #133
Merged
Conversation
Three harnesses put SERIAL inside a mktemp -d dir and rm -rf'd it from an EXIT trap, which fires on failure too -- destroying exactly the panic dump PR #128 added for issue #126. Fixed in PR #131 with the shared verify/preserve-serial.sh; this records the rule and the two traps that make it non-obvious (key on exit status rather than a parsed verdict, and capture rc=$? as the trap's first action before cleanup_qemu resets it). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEkhAhgTxbE5TgifyYf8v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #131.
Three harnesses put
SERIALinside amktemp -ddir andrm -rf'd it from an EXIT trap — which fires on failure too, destroying exactly the panic dump PR #128 added for issue #126. #131 fixed that with the sharedverify/preserve-serial.sh; this records the rule in CLAUDE.md along with the two traps that make it non-obvious:set -e, a QEMU timeout, or a typist TIMEOUT never prints a verdict, and those are the runs worth keeping;rc=$?as the trap's first action, because any earlier command (cleanup_qemu) succeeds and resets$?. Unit tests that call the helper first in the trap pass against that bug; only the real trap shape catches it.🤖 Generated with Claude Code
https://claude.ai/code/session_01CEkhAhgTxbE5TgifyYf8v4