Skip to content

test(agy): [DO NOT MERGE] live-confirm the large-diff handoff#329

Closed
doublegate wants to merge 1 commit into
mainfrom
test/agy-handoff-live-confirm
Closed

test(agy): [DO NOT MERGE] live-confirm the large-diff handoff#329
doublegate wants to merge 1 commit into
mainfrom
test/agy-handoff-live-confirm

Conversation

@doublegate

Copy link
Copy Markdown
Owner

Throwaway — do not merge. Adds a >125 KB fixture so the diff exceeds the reviewer's inline budget, forcing the on-disk file handoff. Purpose: confirm live (real workflow + runner + agy) that the absolute-path + --add-dir fix from #328 makes the large-diff handoff readable. Expect the agy review to actually read the diff (no "does not exist") and report no blocking issues. Closing + deleting the branch once confirmed.

🤖 Generated with Claude Code

DO NOT MERGE. Adds a >125 KB markdown fixture so this PR's diff exceeds the
Antigravity reviewer's inline budget (and the argv ceiling), forcing the on-disk
file-handoff path. Reviewed by the now-fixed reviewer on `main` (PR #328), this
validates end-to-end — real workflow + self-hosted runner + agy — that the
absolute-path + `--add-dir` handoff is readable. The branch is deleted once the
review confirms agy read the diff (no "does not exist on the filesystem").

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • tools/agy-selftest/large-diff-handoff-fixture.md
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5f0cb55e-cfeb-4903-ace5-b722afecfe26

📥 Commits

Reviewing files that changed from the base of the PR and between 68c9643 and 28e9185.

📒 Files selected for processing (1)
  • tools/agy-selftest/large-diff-handoff-fixture.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/agy-handoff-live-confirm

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Antigravity review (Gemini via Ultra)

This PR adds a 3,447-line Markdown test fixture (tools/agy-selftest/large-diff-handoff-fixture.md) containing repetitive filler text to test on-disk diff handoff handling for large PRs.

Blocking issues

None found.

Suggestions

  • tools/agy-selftest/large-diff-handoff-fixture.md: L1-3454: Adding a ~230 KB static text file to the repository solely to inflate diff size increases repository bloat; consider generating large test inputs dynamically within the test runner instead of committing static filler.

Nitpicks

  • The file header notes "Never merged"; ensure this PR is closed or cleaned up after testing to avoid accidentally checking in throwaway test artifacts.

Automated first-pass review by agy on a self-hosted runner -- not a human review.

@doublegate

Copy link
Copy Markdown
Owner Author

Live confirmation succeeded. The agy review above read the full 229 KB diff from the on-disk handoff (it accurately summarized the 3,447-line fixture and its intent, and even quoted the in-file "Never merged" note) with no "does not exist" failure and no blocking issues — proving the absolute-path + --add-dir fix from #328 works end-to-end on the real workflow + self-hosted runner against a >125 KB diff. Closing as intended; this was a throwaway validation, never to be merged.

@doublegate doublegate closed this Jul 24, 2026
@doublegate
doublegate deleted the test/agy-handoff-live-confirm branch July 24, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant