fix: realtime param/prompt correctness + cosine_weighted interpolation + text-encoder perf#18
Open
forkni wants to merge 13 commits into
Open
fix: realtime param/prompt correctness + cosine_weighted interpolation + text-encoder perf#18forkni wants to merge 13 commits into
forkni wants to merge 13 commits into
Conversation
…4, similar-filter on, do_add_noise true)
…d (eliminates per-frame RCFG cold-restart)
…start (matches reference fork)
…n do_add_noise=False bleed regime _update_timestep_calculations (stream_parameter_updater.py) now keeps the pre-computed shifted tensors _alpha_next, _beta_next, _init_noise_rotated in sync after a value-only t_index_list update. Previously they were only built in prepare() and the error-fallback _refresh_derived_tensors(), causing stale RCFG-self stock_noise rotation at guidance > 1.0 when the user changed Tindexblockstep at runtime (F2 fix). Also adds a logged warning when do_add_noise=False is combined with use_denoising_batch and a high-noise inter-step timestep (beta_sqrt > 0.75). With do_add_noise=False the inter-step x_t_latent_buffer carries zero noise content (alpha_sqrt * x0_pred only), causing the UNet to ghost-bleed previous frames once beta_sqrt crosses ~0.78 (empirically at t_index_list[1] < 30 in a 50-step LCM schedule). Root cause: do_add_noise=False violates the on-manifold assumption; reference fork default is True. Diagnosis confirmed via beta_curve.py (tmp_debug/, not committed): beta_sqrt ranges from 0.61 at idx=36 to 0.78 at idx=29, matching the observed threshold. 6 CPU-only regression tests added (tests/unit/test_derived_tensor_sync.py).
…ith scheduler rebuild
forkni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Branch
feat/v2v-rcfg-correctness->SDTD_031_dev